-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Release Diff Action #737
Conversation
Fixes #548 proof of concept: obophenotype/cell-ontology#1730 personally I think this action can be distributed regardless of trigger cause it doesn't trigger unless triggered by keyword, but im playing it safe with this.
So this is how you add your actions to ODK, thanks for sharing. |
Lets figure it out on the CL side first. I think there are some pieces missing, like "running the release" first! |
@ubyndr Please advice the state of this and drive it forward :) Thanks! |
This is our action in CL to post the release diff, which is much simpler than the one in this PR. I'll update here. |
We need to change where ODK saves the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for you question about where to put it, I would be inclined against adding a new directory and instead unignoring the file in the report directory with !
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, then I think this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! THANKS for pushing this over the finish line!
Fixes #548
proof of concept: obophenotype/cell-ontology#1730
please do help me ensure i didnt do anything stupid - i have a proneness to doing that
personally I think this action can be distributed regardless of trigger cause it doesn't trigger unless triggered by keyword, but im playing it safe with this.