Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Diff Action #737

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Add Release Diff Action #737

merged 6 commits into from
Jan 4, 2024

Conversation

shawntanzk
Copy link
Contributor

Fixes #548

proof of concept: obophenotype/cell-ontology#1730

please do help me ensure i didnt do anything stupid - i have a proneness to doing that

personally I think this action can be distributed regardless of trigger cause it doesn't trigger unless triggered by keyword, but im playing it safe with this.

Fixes #548

proof of concept: obophenotype/cell-ontology#1730

personally I think this action can be distributed regardless of trigger cause it doesn't trigger unless triggered by keyword, but im playing it safe with this.
@shawntanzk shawntanzk self-assigned this Nov 15, 2022
@ubyndr
Copy link

ubyndr commented Nov 15, 2022

So this is how you add your actions to ODK, thanks for sharing.

@matentzn
Copy link
Contributor

Lets figure it out on the CL side first. I think there are some pieces missing, like "running the release" first!

@matentzn matentzn marked this pull request as draft November 26, 2022 16:12
@matentzn matentzn added this to the 1.3.3 milestone Dec 4, 2022
@matentzn
Copy link
Contributor

@ubyndr Please advice the state of this and drive it forward :) Thanks!

@matentzn matentzn assigned ubyndr and unassigned shawntanzk Feb 16, 2023
@anitacaron
Copy link
Contributor

This is our action in CL to post the release diff, which is much simpler than the one in this PR. I'll update here.

@matentzn matentzn assigned anitacaron and unassigned ubyndr Dec 11, 2023
@matentzn matentzn self-requested a review December 11, 2023 14:15
@anitacaron
Copy link
Contributor

We need to change where ODK saves the release-diff.md. Right now, it's in src/ontology/reports/release-diff.md, which is in the .gitignore. On CL/UBERON, it's saved in src/ontology/diffs/. This workflow is expecting the file there.

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for you question about where to put it, I would be inclined against adding a new directory and instead unignoring the file in the report directory with !.

template/_dynamic_files.jinja2 Outdated Show resolved Hide resolved
template/_dynamic_files.jinja2 Outdated Show resolved Hide resolved
template/_dynamic_files.jinja2 Outdated Show resolved Hide resolved
@anitacaron anitacaron marked this pull request as ready for review January 3, 2024 19:36
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment, then I think this is good to go.

template/_dynamic_files.jinja2 Show resolved Hide resolved
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! THANKS for pushing this over the finish line!

@anitacaron anitacaron merged commit 7a3aaa5 into master Jan 4, 2024
1 check passed
@anitacaron anitacaron deleted the add-release-diff-action branch January 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow: post comment with Robot diff for release
5 participants