Skip to content
This repository has been archived by the owner on Sep 27, 2018. It is now read-only.

add setup.py and versioneer #6

Merged
merged 1 commit into from
Sep 12, 2018
Merged

add setup.py and versioneer #6

merged 1 commit into from
Sep 12, 2018

Conversation

tyarkoni
Copy link
Collaborator

@tyarkoni tyarkoni commented Sep 8, 2018

@chrisfilo: this is a start toward #1; I've added versioneer and a setup.py file. Do you mind setting up PyPI release from CI? I can also do it if you prefer, but I figure you'd want to use your credentials, plus I have no experience fiddling with circle's config.

I'd recommend changing the common folder to bids_validator instead of bids_validator_common for clarity and brevity, but left that up to you to decide.

@chrisgorgo chrisgorgo requested a review from nellh September 9, 2018 23:43
Copy link
Collaborator

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I do agree with the rename to bids_validator vs bids_validator_common, @bGrass is working on merging this into the main repo along with that change.

@nellh nellh merged commit 31b653a into master Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants