Add TE Condition content

[mikedstrong]

Hi John,

I work at TE Connectivity for "tematt", who submitted a pull request on August 31, 2018 to add some condition content that we require. At that time, you identified a number of problems with the code in the pull request, including the fact that it would not compile. Then, 15 days ago, on January 11, you again communicated via email with Matt when you closed the pull request. Matt asked me to look at your comments and see if I could address the problems you pointed out. I believe I have fixed the problems you identified and added the condition content we require.

Please consider this pull request and let know if you have any questions.

Thanks!
Mike

[ChrisJorgensen]

Hi, Mike. John is going to review your fixes and get back to you with feedback. We are about to publish version 1.3 of the standard, so if your proposal requires any updates to the standard, we will get those in version 1.4, which we will publish early this year. John should be in touch with you soon regarding any feedback on your proposal. Chris [cid:[email protected]]<https://www.ipc.org/> [cid:[email protected]]<https://www.ipc.org/facebook> [cid:[email protected]] <https://www.ipc.org/twitter> [cid:[email protected]] <https://www.ipc.org/youtube> [cid:[email protected]] <https://www.ipc.org/linkedin> [cid:[email protected]] <https://www.instagram.com/ipcassociation/> Chris Jorgensen | Director. Technology Transfer IPC [cid:[email protected]] 3000 Lakeside Drive, Suite 105 N, Bannockburn, IL 60015 [cid:[email protected]] +1 847 597-2826 [cid:[email protected]] +1 773 682-2900 [cid:[email protected]] [email protected]<mailto:[email protected]> [cid:[email protected]] www.ipc.org<http://www.ipc.org/> From: mikedstrong <[email protected]> Sent: Tuesday, January 26, 2021 12:44 PM To: IPCConnectedFactoryExchange/CFX <[email protected]> Cc: Subscribed <[email protected]> Subject: [IPCConnectedFactoryExchange/CFX] Add TE Condition content (#112) Hi John, I work at TE Connectivity for "tematt", who submitted a pull request on August 31, 2018 to add some condition content that we require. At that time, you identified a number of problems with the code in the pull request, including the fact that it would not compile. Then, 15 days ago, on January 11, you again communicated via email with Matt when you closed the pull request. Matt asked me to look at your comments and see if I could address the problems you pointed out. I believe I have fixed the problems you identified and added the condition content we require. Please consider this pull request and let know if you have any questions. Thanks! Mike

…

________________________________ You can view, comment on, or merge this pull request online at: #112 Commit Summary * Add TE Condition content File Changes * M CFX/Production/Assembly/PressInsertion/ConditionCompleted.cs<https://github.com/IPCConnectedFactoryExchange/CFX/pull/112/files#diff-6a9b222b35e990fd0f29f208d5d3c6e06ffb7876fe4d8582710b8f13b26634ee> (20) * A CFX/Production/Assembly/PressInsertion/ConditionStarted.cs<https://github.com/IPCConnectedFactoryExchange/CFX/pull/112/files#diff-f9c2d34c9db2c34c8cba8374680032dc5f07d43b90cb9452d4063f468ad6a074> (81) * M CFX/Production/Assembly/PressInsertion/GetConditionPermissionRequest.cs<https://github.com/IPCConnectedFactoryExchange/CFX/pull/112/files#diff-82af156095ecf5d120436b9533f1f4d2baa9afe8f705221ba1e7435dd53e1bf5> (9) * M CFX/Production/Assembly/PressInsertion/GetConditionPermissionResponse.cs<https://github.com/IPCConnectedFactoryExchange/CFX/pull/112/files#diff-543f669835f23390174746df7a6d1f79a1168579058f809f211b868835d420e8> (11) Patch Links: * https://github.com/IPCConnectedFactoryExchange/CFX/pull/112.patch * https://github.com/IPCConnectedFactoryExchange/CFX/pull/112.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#112>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALWUHA4NZWWG2ZG33SXY6KTS34EPDANCNFSM4WT5TJKA>.

[johnjwalls]

Old stale request. No response to inquiries. Closing for now.

[tematt]

please resend message directly to me as if there was communication as indicated above - that user is no longer active for this project

[ChrisJorgensen]

Mike, we want to try to work this pull request into the standard, but there are still questions regarding this. Can you email me directly to [email protected] so we can invite you to a CFX A-Team meeting to discuss this?

[Siox0911]

Mike, we want to try to work this pull request into the standard, but there are still questions regarding this. Can you email me directly to [email protected] so we can invite you to a CFX A-Team meeting to discuss this?

I deleted the questions. When I looked through them again, it explains what ConditionName is. Although it should be discussed whether it really has to be free text. An enum would be better in a standard because it avoids misinterpretation. It is not a problem to extend an enum. But free text invites everyone to do their own thing. Could you please invite me back to the A-Team?