Modernize nuget package and unify CFX project targets #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't get the units tests to work, but that doesn't seem to be an issue with the build or project changes, but rather the test setup itself. With the PR the package should be publishable using: dotnet pack ./CFX/CFX.csproj
dotnet push ./CFX/CFX.csproj |
|
Once this is complete, I'd also like to backport this to 1.7 as well, as the equipment with work with is on version 1.X |
|
Thank you for your input. Would you be willing to submit a pull request via Github to make these changes?
Chris
***@***.***<https://www.ipc.org/>
***@***.***<https://www.ipc.org/facebook> ***@***.*** <https://www.ipc.org/twitter> ***@***.*** <https://www.ipc.org/youtube> ***@***.*** <https://www.ipc.org/linkedin> ***@***.*** <https://www.instagram.com/ipcassociation/>
Chris Jorgensen | Director, Technology Transfer (He/Him/His)
IPC
***@***.*** 3000 Lakeside Drive, Suite 105 N, Bannockburn, IL 60015
***@***.*** +1 847 597-2826
***@***.*** +1 773 771-9411
***@***.*** ***@***.******@***.***>
***@***.*** www.ipc.org<http://www.ipc.org/>
From: T. Langhorst ***@***.***>
Sent: Wednesday, January 8, 2025 7:38 AM
To: IPCConnectedFactoryExchange/CFX ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [IPCConnectedFactoryExchange/CFX] Modernized nuget package and unified CFX project targets (PR #223)
I can't get the units tests to work, but that doesn't seem to be an issue with the build or project changes, but rather the test setup itself.
With the PR the package should be publishable using:
dotnet pack ./CFX/CFX.csproj
dotnet push ./CFX/CFX.csproj
—
Reply to this email directly, view it on GitHub<#223 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALWUHAY32YXRKUE37QI4VBL2JUS2RAVCNFSM6AAAAABUZ4X77KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZXGY4TEMZXG4>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
Already have, you replied to the GitHub notification of the Pull Request |
megla-tlanghorst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for fix of #222
This unifies .NET, .NET Standard and .NET Framework into a single package, should generate the correct source link metadata and includes documentation for all targets.
I also removed
CFXnet46.csproj.bak,CFX_JSON_Examples.txtandContent Layout.contentas it seems someone intended them to be removed, but only removed them from Visual Studio, leaving the actual files there.