Skip to content

Commit

Permalink
@GitHK review: doc
Browse files Browse the repository at this point in the history
  • Loading branch information
pcrespov committed Nov 8, 2022
1 parent 1c2fc6b commit a737c33
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def _iter_project_ports(
and node.key.startswith("simcore/services/frontend/parameter/")
and node.outputs
):
# invariants
assert not node.inputs # nosec
assert list(node.outputs.keys()) == ["out_1"] # nosec

Expand All @@ -76,7 +75,6 @@ def _iter_project_ports(
)
and node.inputs
):
# invariants
assert not node.outputs # nosec
assert list(node.inputs.keys()) == ["in_1"] # nosec

Expand Down Expand Up @@ -141,11 +139,11 @@ def get_project_outputs(workbench: dict[NodeID, Node]) -> dict[NodeID, Any]:
for port in _iter_project_ports(workbench, "output"):
if port.node.inputs:
try:
# is link?
# Is link?
port_link = _NonStrictPortLink.parse_obj(port.node.inputs["in_1"])
# resolve
node = workbench[port_link.node_uuid]
# might still not have results
# If the node has not results (e.g. did not run or failed), then node.outputs is set to None
value = node.outputs[port_link.output] if node.outputs else None
except ValidationError:
# not a link
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ async def test_io_workflow(
mock_catalog_service_api_responses: None,
expected: type[web.HTTPException],
):
"""This tests implements a minimal workflow to support the MVP
"""This tests implements a minimal workflow
It later stage, this test might be split into smaller unit-tests
"""
Expand Down

0 comments on commit a737c33

Please sign in to comment.