Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 73 #80

Merged
merged 13 commits into from
Dec 15, 2023
Merged

Issue 73 #80

merged 13 commits into from
Dec 15, 2023

Conversation

ChernyakKonstantin
Copy link
Collaborator

Apply changes suggested in issue #73

There is also small reformatting and documentation extension.

@ChernyakKonstantin
Copy link
Collaborator Author

I need some help on the examples/4_advising_models/advise_by_surrogate.py example testing.

My current version of PyTorch is 2.1.0 that is not compatible with surrogate model.

Who can run the example, please, report whether it works properly. Otherwise, provide me version of PyTorch that you have if you can run the example.

Copy link
Collaborator

@MorrisNein MorrisNein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Идём верным курсом, спасибо! Осталось немного

@ChernyakKonstantin
Copy link
Collaborator Author

Идём верным курсом, спасибо! Осталось немного

Удалось проверить пример на работоспособность?

@pep8speaks
Copy link

pep8speaks commented Nov 24, 2023

Hello @ChernyakKonstantin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: F401 'meta_automl.meta_algorithm.model_advisors.model_advisor.DatasetSimilarityModelAdvisor' imported but unused
Line 1:1: F401 'meta_automl.meta_algorithm.model_advisors.model_advisor.ModelAdvisor' imported but unused
Line 2:1: F401 'meta_automl.meta_algorithm.model_advisors.diverse_model_advisor.DiverseModelAdvisor' imported but unused
Line 3:1: F401 'meta_automl.meta_algorithm.model_advisors.surrogate_advisor.SurrogateGNNModelAdvisor' imported but unused

Comment last updated at 2023-12-13 12:11:15 UTC

@MorrisNein
Copy link
Collaborator

Удалось проверить пример на работоспособность?

Да, с небольшими фиксами запустил.

@ChernyakKonstantin
Copy link
Collaborator Author

Да, с небольшими фиксами запустил.

Напиши версию pytorch и PyTorch_geometric, с которыми удалось запустить.

@MorrisNein
Copy link
Collaborator

MorrisNein commented Nov 24, 2023

Напиши версию pytorch и PyTorch_geometric, с которыми удалось запустить.

pytorch-lightning==2.0.5
torch==2.0.0+cpu
torch-geometric==2.3.0
torch-scatter==2.1.2+pt20cpu
torchmetrics==0.11.4
torchvision==0.15.1+rocm5.4.2

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (ce147ff) 28.39% compared to head (fb879ca) 28.58%.

Files Patch % Lines
...meta_algorithm/model_advisors/surrogate_advisor.py 0.00% 20 Missing ⚠️
...a_automl/meta_algorithm/model_advisors/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   28.39%   28.58%   +0.18%     
==========================================
  Files          54       54              
  Lines        2317     2302      -15     
==========================================
  Hits          658      658              
+ Misses       1659     1644      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorrisNein
Copy link
Collaborator

Пофиксил конфликты, вызванные моими недавними правками. Также адаптировал пример

@ChernyakKonstantin ChernyakKonstantin merged commit 2dba7d3 into main Dec 15, 2023
2 of 3 checks passed
@ChernyakKonstantin ChernyakKonstantin deleted the issue_73 branch December 15, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants