[NDTensors] Remove ITensors dependency from tests
#1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
ITensors.jlas a dependency from the NDTensors tests. Having it as a test dependency makes it awkward when we want to make breaking releases of ITensors.jl, since then that can break the tests of NDTensors (this came up in #1551).@kmp5VT DMRG was being used as a test of the GPU backends but we should instead make sure we have good test coverage of the various operations used by DMRG, like contraction, SVD, QR, eigendecomposition, etc.
We can also move the test of DMRG on different GPU backends to the new
ITensorMPS.jlrepository once it is set up: ITensor/ITensorMPS.jl#31, we'll have to get Jenkins set up there.