Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript code cleanup #29

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Javascript code cleanup #29

merged 1 commit into from
Oct 15, 2023

Conversation

jim3692
Copy link
Collaborator

@jim3692 jim3692 commented Oct 13, 2023

This PR may not add much value, but it has some changes that are needed for the rework we are doing in the react-mui-port branch.

EDIT: It looks like it fixes some bugs

@jim3692 jim3692 changed the title Code cleanup Javascript code cleanup Oct 13, 2023
@IceDBorn
Copy link
Owner

What bugs?

@jim3692
Copy link
Collaborator Author

jim3692 commented Oct 13, 2023

It turns out All Desktop Audio is a bit unstable, at least on my PC. Somehow this PR makes it more stable.

@jim3692 jim3692 requested a review from IceDBorn October 13, 2023 23:29
@IceDBorn IceDBorn merged commit 25870bf into main Oct 15, 2023
@IceDBorn IceDBorn deleted the popup-rework branch October 15, 2023 13:11
@IceDBorn IceDBorn mentioned this pull request Oct 15, 2023
8 tasks
@IceDBorn IceDBorn linked an issue Oct 15, 2023 that may be closed by this pull request
8 tasks
@IceDBorn IceDBorn removed a link to an issue Oct 15, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants