-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icinga states to job #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6536a7f
to
00c9104
Compare
|
|
lippserd
requested changes
Jul 25, 2024
pkg/schema/v1/job.go
Outdated
@@ -166,6 +171,28 @@ func (j *Job) Obtain(k8s kmetav1.Object) { | |||
j.Yaml = string(output) | |||
} | |||
|
|||
func (j *Job) getIcingaState(job *kbatchv1.Job) (IcingaState, string) { | |||
if gracePeriodReason := IsWithinGracePeriod(j); gracePeriodReason != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for a grace period as we will do the following:
- If condition is complete, return ok: Job .. has finished its execution successfully with %d necessary pod completions.
- If condition is failed, return critical. Message should stay the same.
- If condition is suspend, return unknown. Message should indicate that the job is suspended.
- If none of the above applies, return pending. Job .. is running since %s with currently %d active, %d completed and %d failed pods. Successful termination requires %d pod completions. The back-off limit is %d.
- If ActiveDeadlineSeconds is set, the pending message should be extended: Deadline for completion is %s.
schema/mysql/schema.sql
Outdated
@@ -792,6 +792,8 @@ CREATE TABLE job ( | |||
succeeded int unsigned NOT NULL, | |||
failed int unsigned NOT NULL, | |||
yaml mediumblob DEFAULT NULL, | |||
icinga_state enum('pending', 'ok', 'warning', 'critical', 'unknown') COLLATE utf8mb4_unicode_ci NOT NULL, | |||
icinga_state_reason text NULL DEFAULT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change that to NOT NULL
as well.
00c9104
to
bc2dd0a
Compare
bc2dd0a
to
6159e9a
Compare
6159e9a
to
1921b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.