Don't parse YAML config twice & drop superfluous code #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
drop-superfluous-code
branch
from
8cef88a to
a5e4c75
Compare
|
I have no idea why |
lippserd
force-pushed
the
drop-superfluous-code
branch
from
a5e4c75 to
c7e3f47
Compare
A simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the YAML config is loaded twice, first into a
database.Configfrom our Icinga Go library and into the customdatabase.Config, which is not necessary. This PR drops the customdatabase.Configand thedatabase.Optionsand uses the Icinga Go library instead, as they don't have any differences, so the YAML does not need to be loaded twice.