Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uuids #93

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Uuids #93

merged 3 commits into from
Jun 3, 2024

Conversation

jhoxhaa
Copy link
Collaborator

@jhoxhaa jhoxhaa commented May 28, 2024

No description provided.

@jhoxhaa jhoxhaa requested a review from lippserd May 28, 2024 18:34
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 28, 2024
@jhoxhaa jhoxhaa self-assigned this May 28, 2024
@jhoxhaa jhoxhaa force-pushed the uuids branch 2 times, most recently from 9c1c30e to 482364d Compare May 29, 2024 11:59
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding schema.sql: There are some uuid columns that still have binary(20) but should be binary(16).

schema/mysql/schema.sql Show resolved Hide resolved
@lippserd
Copy link
Member

lippserd commented Jun 2, 2024

Also, please rebase.

@lippserd lippserd merged commit 1b6c845 into main Jun 3, 2024
7 checks passed
@lippserd lippserd deleted the uuids branch June 3, 2024 07:44
@lippserd lippserd mentioned this pull request Jun 4, 2024
@lippserd lippserd added this to the 0.2.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants