Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Host|Service) Detail view: Introduce parents and children tab #1098

Merged
merged 14 commits into from
Jan 22, 2025
Merged

(Host|Service) Detail view: Introduce parents and children tab #1098

merged 14 commits into from
Jan 22, 2025

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Nov 25, 2024 •
edited
Loading

TODO

@sukhwinder33445 sukhwinder33445 self-assigned this Nov 25, 2024
@sukhwinder33445 sukhwinder33445 changed the base branch from main to dependencies November 25, 2024 14:19
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 59dc8c9 to 74bb945 Compare December 5, 2024 10:16
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 5, 2024
@nilmerg nilmerg linked an issue Dec 9, 2024 that may be closed by this pull request
List views for parents and children #1063
Closed
nilmerg
nilmerg requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the issue:

The tabs are only visible if the object is linked in the database table dependency_node.

The tabs are always visible right now.

@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from c37ece0 to 9ab8072 Compare December 16, 2024 09:21
@raviks789
Copy link
Contributor

Except for the error in the search bar while trying to apply filter in Parents/Children tabs, everything else seems to work as listed out in the issue.

raviks789
raviks789 reviewed Dec 17, 2024
View reviewed changes
application/controllers/HostController.php Outdated Show resolved Hide resolved
application/controllers/HostController.php Outdated Show resolved Hide resolved
application/controllers/HostController.php Outdated Show resolved Hide resolved
application/controllers/HostController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Show resolved Hide resolved
application/controllers/HostController.php Show resolved Hide resolved
public/css/list/redundancy-group-list-item.less Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from fb557c7 to 03a160d Compare December 18, 2024 16:35
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 03a160d to 2caf0ae Compare January 9, 2025 10:22
@nilmerg nilmerg requested a review from raviks789 January 15, 2025 14:10
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch 3 times, most recently from df52697 to 25d1b6b Compare January 16, 2025 10:40
nilmerg
nilmerg requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to review HostController::joinFix, can't wrap my head around it right now…

application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/ServiceController.php Show resolved Hide resolved
application/controllers/ServiceController.php Show resolved Hide resolved
application/controllers/HostController.php Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from 013432d to 0564431 Compare January 17, 2025 11:33
nilmerg
nilmerg requested changes Jan 20, 2025
View reviewed changes
application/controllers/ServiceController.php Outdated Show resolved Hide resolved
application/controllers/HostController.php Outdated Show resolved Hide resolved
public/css/list/redundancy-group-list-item.less Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 0564431 to aa33908 Compare January 20, 2025 13:43
This was referenced Jan 20, 2025
Closed
Closed
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from b08fdea to 8704ec0 Compare January 21, 2025 10:48
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 8704ec0 to f21a691 Compare January 22, 2025 11:37
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from f21a691 to 8090c1f Compare January 22, 2025 11:40
nilmerg
nilmerg approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@sukhwinder33445
(Host|Service)Controller: Let the init() render the object header
645ae00
@sukhwinder33445
(Host|Service)Controller: Add parents and children tab
ad8d71b
@sukhwinder33445
(Host|Service)Controller: Shift the required param
d5d36d7 
- Otherwise the searchbar uses it as base filter and apply it on the query
@sukhwinder33445
(Host|Service)Controller: Fix tab activation
5e436dc 
- Set the outer tab as active.

Previously, the inner tab was activated in the setTitleTab method, but the outer tab does not know about the state of inner tabs.
So whenever sendMultipartUpdate() -> getActiveTab() was called, the retured value was always null.
@sukhwinder33445
(Host|Service)Controller: Add return type to methods
1ceb351
@sukhwinder33445
Add view mode functionality for RedundancyGroup items
18ba5a3
@sukhwinder33445
Add csv/json export support for parents and children tab
cda2f4b
@sukhwinder33445
Don't show parents children tab if icingadb.schema does not sup…
b69fb09 
…port it
@sukhwinder33445
(Host|Service)Controller: Use Translation trait method
6aa32fa
@sukhwinder33445
(Host|Service)Controller: Sort parents children tab list by default t…
41601ab 
…o `severity`

- Disable the default sorting for the `$hasDependencyNode` and UnreachableParent's `$rootQuery`, as sort is not required here
and triggers an error, because the sort columns are not retrieved.
@sukhwinder33445
(Host/Service)Controller: Change method name and fix syntax
3602d5a
@sukhwinder33445
(Host/Service)Controller: Add separated `(searchEditor/complete)Actio…
ebdb48a 
…n` for `parent & children tab`
@sukhwinder33445
RedundancyGroup: Don't wrap state msg into span and translate it wi…
efe8d77 
…th context

This msg should be handled same as the host <is/on> word, no element wrapping.
This way, the margin arround the msg is applied properly.

- Add the missing margin-right to subject in case of `.default-layout` list
@sukhwinder33445
(Host/Service)Controller: Add missing onlyWithCustomVarSources() call
667fd2f
@sukhwinder33445 sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 8090c1f to 667fd2f Compare January 22, 2025 12:44
@nilmerg nilmerg merged commit 3663a7a into dependencies Jan 22, 2025
22 checks passed
@nilmerg nilmerg deleted the introduce-parents-children-tab branch January 22, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviks789 raviks789 raviks789 approved these changes

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List views for parents and children
3 participants
@sukhwinder33445 @raviks789 @nilmerg