Extend tests

Icinga · Aug 2, 2024 · 55dec68 · 55dec68
1 parent 2b9e797
commit 55dec68
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -12,6 +12,7 @@ _icingaweb2/
 _libraries/
 .phpunit.cache/
 .phplint.cache/
+reports/
 /docker-compose.yml
 /*.phar
 /Icinga

diff --git a/application/controllers/ShowController.php b/application/controllers/ShowController.php
@@ -71,7 +71,12 @@ public function treeAction()
     {
         $this->view->name = $name = $this->params->getRequired('name');
 
-        $c = new ViewConfig();
+        $config_dir_module = Icinga::app()
+                           ->getModuleManager()
+                           ->getModule('toplevelview')
+                           ->getConfigDir();
+
+        $c = new ViewConfig($config_dir_module);
 
         // Check if the user has permissions/restrictions for this View
         $restrictions = $c->getRestrictions('toplevelview/filter/views');
@@ -95,7 +100,12 @@ public function sourceAction()
     {
         $this->view->name = $name = $this->params->getRequired('name');
 
-        $c = new ViewConfig();
+        $config_dir_module = Icinga::app()
+                           ->getModuleManager()
+                           ->getModule('toplevelview')
+                           ->getConfigDir();
+
+        $c = new ViewConfig($config_dir_module);
 
         // Check if the user has permissions/restrictions for this View
         $restrictions = $c->getRestrictions('toplevelview/filter/views');

diff --git a/test/php/library/Toplevelview/ViewConfigTest.php b/test/php/library/Toplevelview/ViewConfigTest.php
@@ -23,5 +23,12 @@ public function testViewConfigWithNoError()
         $view = $c->loadByName('example');
 
         $this->assertStringContainsString('linux-servers', $view->getText());
+        $this->assertSame('5fc0ad55066b871d376eee60c84300d32ac7cb1d', $view->getTextChecksum());
+        $this->assertSame('yml', $view->getFormat());
+        $this->assertSame('example', $view->getName());
+
+        $clone = clone $view;
+        $this->assertSame(null, $clone->getName());
+        $this->assertFalse($clone->hasBeenLoaded());
     }
 }