Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: Skip receipt authenticity check DO NOT MERGE #92

Closed
wants to merge 1 commit into from

Conversation

schwmi
Copy link
Member

@schwmi schwmi commented Aug 28, 2023

Probably due to https://developer.apple.com/documentation/technotes/tn3138-handling-app-store-receipt-signing-certificate-changes# the call to SecKeyVerifySignature throws and error and leads to a receipt validation error.

This PR temporarily disables the call (for shipping a hot fix) until we implement a replacement for SecKeyVerifySignature .

@schwmi schwmi self-assigned this Aug 28, 2023
@schwmi schwmi requested review from hannesoid and weichsel August 28, 2023 11:15
@schwmi schwmi changed the title Workaround: Skip receipt authenticity check Workaround: Skip receipt authenticity check DO NOT MERGE Aug 28, 2023
Copy link
Member

@weichsel weichsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now. Investigating whether we can re-enable this by changing the way we verify authenticity.

@hannesoid
Copy link
Contributor

Actual fix in the making: #93

@weichsel weichsel closed this Aug 28, 2023
@weichsel
Copy link
Member

Actual fix merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants