Skip to content

Commit

Permalink
Migrate some gradle configs
Browse files Browse the repository at this point in the history
This commit fixes 2 issues
* R8 version was different to the one configured in the plugin
* android.defaults.buildfeatures.buildconfig is deprecated and
to be removed in gradle 9.0

For the former we just need to upgrade the version. For the
latter it's a matter of moving the configuration option from
gradle properties to the app module build.gradle.
  • Loading branch information
svillar committed Nov 6, 2024
1 parent 638ff32 commit 6c29384
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,7 @@ android {
viewBinding true
prefab true // enable prefab support for various SDK AAR
dataBinding true
buildConfig true
}

lint {
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
dependencies {
classpath "org.mozilla.telemetry:glean-gradle-plugin:56.1.0"
classpath "com.android.tools.build:gradle:$versions.android_gradle_plugin"
classpath 'com.android.tools:r8:8.5.35'
classpath 'com.android.tools:r8:8.7.14'
classpath "$deps.kotlin.plugin"
classpath 'com.huawei.agconnect:agcp:1.9.1.301'

Expand Down
1 change: 0 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ android.injected.testOnly=false
android.useAndroidX=true
android.enableJetifier=true

android.defaults.buildfeatures.buildconfig=true
android.nonTransitiveRClass=false
android.nonFinalResIds=false

0 comments on commit 6c29384

Please sign in to comment.