Chromium: Make password saving option independent from autofill option in Privacy settings #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in Privacy settings Currently in Privacy settings in Chromium backend, the password saving option depends on the autofill option. If autofill is disabled, password saving doesn't work whether enabled or not. This is because Chromium doesn't provide an autofill option but provides a login selection dialog that asks users whether to autofill the saved password or not. This commit makes password saving option independent from autofill option. The autofill option now only affects whether to show login selection dialog or not. Fixes Igalia#1707
svillar
requested changes
Jan 31, 2025
| for (int i = 0; i < forms.length; i++) { | ||
| options[i] = new WAutocomplete.LoginSelectOption(fromPasswordForm(forms[i])); | ||
| } | ||
| if (showLoginSelectDialog) { |
There was a problem hiding this comment.
You can leave most of the code unchanged and the change more compact if you invert the condition
if (!showLoginSelectionDialog)
return false;
| for (int i = 0; i < username.length; i++) { | ||
| options[i] = new WAutocomplete.LoginSelectOption(fromUsername(i, username[i])); | ||
| } | ||
| if (showLoginSelectDialog) { |
| // Instead, it provides a login selection dialog that let users decide whether to autofill the saved password or not. | ||
| // We'll only show this dialog if users enable autofill. | ||
| showLoginSelectDialog = SettingsStore.getInstance(context).isAutoFillEnabled(); | ||
| return true; |
There was a problem hiding this comment.
This is not correct. For Gecko it'll return true unconditionally even if autofill is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium: Make password saving option independent from autofill option in Privacy settings
Currently in Privacy settings in Chromium backend, the password saving option depends on the autofill option. If autofill is disabled, password saving doesn't work whether enabled or not. This is because Chromium doesn't provide an autofill option but provides a login selection dialog that asks users whether to autofill the saved password in each login. This commit makes password saving option independent from autofill option. The autofill option now only affects whether to show login selection dialog or not.
Fixes #1707