IECoreBinding : Use Py_ssize_t
#1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC has `SSIZE_T`, but not `ssize_t`, which is not part of the standard it seems. Python's `pyport.h` file does a `typedef` for it, but something must have changed between Python `3.7` and `3.10` that causes that to not be included from what we're using. It does seem that the official recommendation is to use `Py_ssize_t` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC has
SSIZE_T, but notssize_t, which is not part of the standard it seems. Python'spyport.hfile does atypedeffor it (typedef ssize_t Py_ssize_t), but something must have changed between Python3.7and3.10that causes that to not be included from what we're using. It does seem that the official recommendation is to usePy_ssize_tnow.This is needed for building Cortex with Python 3.10 dependencies packages.
Checklist