Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderStateComponent : Handle ToGLTextureConverter exceptions #1418

Merged
merged 1 commit into from
May 28, 2024
Merged

ShaderStateComponent : Handle ToGLTextureConverter exceptions #1418

merged 1 commit into from
May 28, 2024

Commits on May 23, 2024

  1. ShaderStateComponent : Handle ToGLTextureConverter exceptions 

    These were thrown if a GLSL shader had bad values for a texture parameter - the case that motivated this was a custom setup in production that would pass a CompoundData with no channels and an empty data window.

We can't let the exception propagate because `addParametersToShaderSetup()` is called during drawing and the exception would prevent the rest of the scene drawing and/or lead to a corrupted GL state.
    @johnhaddon
    johnhaddon committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f233bdd View commit details
    Browse the repository at this point in the history