USD fixes #1420
Merged
USD fixes #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now return a sentinel instead of throwing an exception. This is consistent with our existing handling of types known to `dispatch()` but without a corresponding USD type.
In conjunction with the previous commit, this means that we now gracefully print a warning message for any parameter types we can't write to USD. Prior to this we were throwing a not very helpful exception and not writing anything at all. This came up in production with a GLSL shader with an ImagePlug input in Gaffer, where we pack an entire image into a CompoundData value.
Since 0590bbf, they have been converted to light parameters instead.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of bugs in USDScene.