OpenImageIOAlgo : Add missing array handlers to data()
#1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And consolidate the existing array handling to use the same templated function as everything else. This new version is preferable because it doesn't initialise the data twice (previously the `resize()` was doing a redundant initialisation prior to the `copy()`). This fixes the loading of ICCProfile metadata, which is the underlying problem reported in https://groups.google.com/g/gaffer-dev/c/qUSJ-r0XuYI/m/y4OMtrBUAAAJ.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And consolidate the existing array handling to use the same templated function as everything else. This new version is preferable because it doesn't initialise the data twice (previously the
resize()was doing a redundant initialisation prior to thecopy()).This fixes the loading of ICCProfile metadata, which is the underlying problem reported in https://groups.google.com/g/gaffer-dev/c/qUSJ-r0XuYI/m/y4OMtrBUAAAJ.