CurvesAlgo::resamplePrimitiveVariables : Support periodic curves #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Aug 29, 2024
src/IECoreScene/CurvesAlgo.cpp
Outdated
Comment on lines
203
to
204
| size_t varyingSize; | ||
| if( m_curves->periodic() ) | ||
| { | ||
| varyingSize = m_curves->numSegments( i ); | ||
| } | ||
| else | ||
| { | ||
| varyingSize = m_curves->numSegments( i ) + 1; | ||
| } | ||
|
|
||
| for( size_t j = 0; j < varyingSize; ++j ) |
There was a problem hiding this comment.
Could be a one liner I think :
const size_t varyingSize = m_curves->variableSize( PrimitiveVariable::Varying, i ).
There was a problem hiding this comment.
Same applies to the other changes below...
test/IECoreScene/CurvesAlgoTest.py
Outdated
Comment on lines
494
to
498
| # Work around weird limitation that for resampling Varying -> Vertex the primvar must be stored on curves | ||
| curves["dummy"] = p |
There was a problem hiding this comment.
I briefly tried to figure out why this might be necessary, but failed. Could you educate me?
danieldresser-ie
force-pushed
the
resampleCurves
branch
from
9e6aca8
to
2c37ad1
Compare
|
I've switched to using variableSize, and added some more info to the comment ( looks like there isn't any good reason why CurvesAlgo.resamplePrimitiveVariable is doing weird things, but that's a fix for another day ). Should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how much periodic curves are ever actually used, but as long as our curves type supports them, we probably shouldn't output bogus data for them.