Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

A11y concerns and semantics #150

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

binyamin
Copy link

Fixes #149

Summary

  • Rewrites the markup, to create more semantic HTML and improve accessibility
  • When markup breaks the CSS, this PR updates the CSS.

To-Do

  • sidebar element doesn't exist. Probably meant to be aside.
  • <a> should be <button>, since it doesn't actually open a new URL.
    • "menu" section
    • "channels" section
  • Right now, Every single heading element on the page is an <h3>.
    • The heading-levels should be different, depending on the content. Like an outline.
    • There should always be a top-level heading (h1).
  • The title attribute is not ideal for screen-readers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y concerns and semantics
1 participant