Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purpur-servers: init 1.14.1 up to latest #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heisfer
Copy link

@heisfer heisfer commented Feb 14, 2025

resolves #37

Things Done

  • Updated all purpur builds lock file
  • Updated Readme
  • nix fmt
  • nix flake check
  • Tested pkgs.purpurServers.purpur in own config

Test code

{ inputs, pkgs, ... }:
{
  imports = [ inputs.nix-minecraft.nixosModules.minecraft-servers ];
  nixpkgs.overlays = [ inputs.nix-minecraft.overlay ];

  services.minecraft-servers = {
    enable = true;
    eula = true;
    servers = {
      purpur = {
        enable = true;
        package = pkgs.purpurServers.purpur;
      };
    };
  };
}

Notes

  • Purpur api doesn't store sha256
  • Package is modified version of paper package
  • nix fmt formatted other unrelated files

@Infinidoge
Copy link
Owner

Please revert all formatting changes, they cause a lot of noise in an otherwise clean and straight forward PR.

Additionally, is there any reason why the update script is written to be async? I can't really see any reason why it should be, and it adds unnecessary complexity.

@heisfer
Copy link
Author

heisfer commented Feb 15, 2025

Please revert all formatting changes, they cause a lot of noise in an otherwise clean and straight forward PR.

Sure thing!

Additionally, is there any reason why the update script is written to be async? I can't really see any reason why it should be, and it adds unnecessary complexity.

The reason for that is fastly download old build and generate sha256 hash (since they only support md5 and I believe md5 is deprecated in nix). I'll revert it back to non async since it's no longer needed.

@heisfer
Copy link
Author

heisfer commented Feb 24, 2025

Things changed:

  1. Reverted update.py
  2. Added bad.json so we don't request not found builds each time.
  3. Rechecked java versions.
  4. Added log4j.xml for specific versions.
  5. Formated with nixfmt-rfc-style as it says in flake.nix (CONTRIBUTING.MD says nixpkgs-fmt)

I hope commit message is fit for CONTRIBUTING.md

@heisfer heisfer changed the title Purpur init purpur-servers: init 1.14.1 up to latest Feb 24, 2025
Copy link
Owner

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, small question with regards to the java version selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Purpur servers
2 participants