updated to use injective-core v1.12.1 and the matching cosmos-sdk #218
Conversation
WalkthroughThis update focuses on refining the derivation of traits across various modules in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
packages/injective-std/src/types/cosmos/distribution/v1beta1.rs (1)
4-5: Ensure consistent formatting of derive attributes.Consider placing all derive attributes in a single block for consistency and readability, as seen in other parts of the code.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
packages/injective-std/README.md (1)
25-30: Consider adding a brief explanation for the new command snippet.It would be helpful for users if a brief description of what the new command does and when it should be used is added above the command snippet.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.StoreCodeProposalStoreCodeProposal")] | ||
| #[deprecated] | ||
| pub struct StoreCodeProposal { |
There was a problem hiding this comment.
Use of deprecated struct StoreCodeProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.InstantiateContractProposalInstantiateContractProposal")] | ||
| #[deprecated] | ||
| pub struct InstantiateContractProposal { |
There was a problem hiding this comment.
Use of deprecated struct InstantiateContractProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.InstantiateContract2ProposalInstantiateContract2Proposal")] | ||
| #[deprecated] | ||
| pub struct InstantiateContract2Proposal { |
There was a problem hiding this comment.
Use of deprecated struct InstantiateContract2Proposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.MigrateContractProposalMigrateContractProposal")] | ||
| #[deprecated] | ||
| pub struct MigrateContractProposal { |
There was a problem hiding this comment.
Use of deprecated struct MigrateContractProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.SudoContractProposalSudoContractProposal")] | ||
| #[deprecated] | ||
| pub struct SudoContractProposal { |
There was a problem hiding this comment.
Use of deprecated struct SudoContractProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.ExecuteContractProposalExecuteContractProposal")] | ||
| #[deprecated] | ||
| pub struct ExecuteContractProposal { |
There was a problem hiding this comment.
Use of deprecated struct ExecuteContractProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | ||
| #[proto_message(type_url = "/cosmwasm.wasm.v1.UpdateAdminProposalUpdateAdminProposal")] | ||
| #[deprecated] | ||
| pub struct UpdateAdminProposal { |
There was a problem hiding this comment.
Use of deprecated struct UpdateAdminProposal.
Consider removing or replacing this deprecated struct to avoid potential issues with future compatibility.
There was a problem hiding this comment.
Actionable comments posted: 4
Out of diff range and nitpick comments (1)
packages/injective-std/README.md (1)
Line range hint
18-19: Consider revising the sentence for conciseness and clarity.- In order to generate an individual proto file run: + To generate an individual proto file, run:
|
|
||
| ### Examples | ||
|
|
There was a problem hiding this comment.
Correct grammatical error for clarity.
- Lets try to create the bindings for
+ Let's try to create the bindings forCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
|
|
||
| First create a directory with the dependencies as below: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Specify the language for the fenced code block to improve readability.
- ```
+ ```plaintext|
|
||
| Next generate the proto: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Specify the language for the fenced code block to improve readability.
- ```
+ ```shell| buf generate /Users/wandlitz/go/src/github.com/osmosis-labs/osmosis-rust/packages/proto-build-injective/../../dependencies/injective-core/proto --template /Users/wandlitz/go/src/github.com/osmosis-labs/osmosis-rust/packages/proto-build-injective/buf.gen.yaml --output ./tmp/tmp-protobuf/injective --path /Users/wandlitz/go/src/github.com/osmosis-labs/osmosis-rust/packages/proto-build-injective/../../dependencies/injective-core/proto/injective/auction | ||
| ``` | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Specify the language for the fenced code block to improve readability.
- ```
+ ```shell
injective-stdSummary by CodeRabbit
New Features
Enhancements
Documentation
Refactor