feat: added injective-std-derive #232
Conversation
WalkthroughThe recent changes introduce the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant ProceduralMacro
participant CosmosSDK
participant QuerySystem
Developer->>ProceduralMacro: Define message struct with attributes
ProceduralMacro->>Developer: Generate traits and implementations
Developer->>CosmosSDK: Use generated traits for smart contract
Developer->>QuerySystem: Execute queries using new request structures
QuerySystem->>CosmosSDK: Return results based on query execution
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (9)
- packages/injective-std-derive/Cargo.toml (1 hunks)
- packages/injective-std-derive/README.md (1 hunks)
- packages/injective-std-derive/src/lib.rs (1 hunks)
- packages/injective-std-derive/tests/main.rs (1 hunks)
- packages/injective-std-derive/tests/query.rs (1 hunks)
- packages/injective-std-derive/tests/struct.rs (1 hunks)
- packages/injective-std/Cargo.toml (1 hunks)
- packages/injective-std/README.md (1 hunks)
- packages/injective-std/src/types/cosmos/base/v1beta1.rs (4 hunks)
Files skipped from review due to trivial changes (2)
- packages/injective-std-derive/README.md
- packages/injective-std/README.md
Additional comments not posted (21)
packages/injective-std-derive/tests/main.rs (1)
1-6: LGTM! Verify the test paths.The code changes are approved.
However, ensure that the test paths
tests/struct.rsandtests/query.rsexist and are correctly configured.Verification successful
LGTM!
The test paths
tests/struct.rsandtests/query.rsexist and are correctly configured.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the test files. # Test: Check if the test files exist. Expect: Both files should exist. test -f packages/injective-std-derive/tests/struct.rs && echo "struct.rs exists" || echo "struct.rs missing" test -f packages/injective-std-derive/tests/query.rs && echo "query.rs exists" || echo "query.rs missing"Length of output: 194
packages/injective-std-derive/Cargo.toml (4)
1-6: LGTM! Package metadata is accurate.The package metadata follows standard conventions and is accurate.
10-11: LGTM! Library configuration is correct.The library is correctly configured as a procedural macro.
13-18: LGTM! Dependencies are appropriate and up-to-date.The dependencies listed are appropriate for a procedural macro library and are up-to-date.
20-24: LGTM! Dev-dependencies are appropriate and up-to-date.The dev-dependencies listed are appropriate for development and testing and are up-to-date.
packages/injective-std-derive/tests/struct.rs (3)
1-2: LGTM! Imports are correct and necessary.The imports are correct and necessary for the test.
4-12: LGTM! Struct definition is correct and appropriate.The
MsgCreateDenomstruct is correctly defined and the derived traits are appropriate.
14-21: LGTM! Main function is comprehensive and correctly implemented.The main function comprehensively tests the
MsgCreateDenomstruct and is correctly implemented.packages/injective-std/Cargo.toml (3)
8-8: Verify the version downgrade.The version has been downgraded from
1.13.2-testnetto1.13.0. Ensure this aligns with the project's versioning strategy and doesn't introduce any regressions.
14-14: Verify compatibility withcosmwasm-stdversion2.1.0.The
cosmwasm-stddependency has been updated from1.5.0to2.1.0. Ensure all existing code is compatible with this new version.
15-15: Verify the newinjective-std-derivedependency.The dependency
osmosis-std-derivehas been replaced withinjective-std-deriveversion1.13.0. Ensure this new dependency is correctly integrated and compatible with the existing code.packages/injective-std-derive/tests/query.rs (3)
1-2: Imports look good.The imports from
cosmwasm_stdandinjective_std_deriveare appropriate and necessary for the functionality being tested.
4-13: Struct definition looks good.The
QueryDenomsFromCreatorRequeststruct is defined with appropriate derives and proto annotations. Ensure that the proto annotations align with the expected schema.
14-26: Struct and main function look good.The
QueryDenomsFromCreatorResponsestruct and the main function are defined correctly. The main function tests the conversion of the request struct into aQueryRequest.packages/injective-std-derive/src/lib.rs (7)
7-23: LGTM!The macro
match_kv_attris well-defined and correctly uses pattern matching to verify key-value pairs.
25-125: LGTM!The procedural macro
derive_cosmwasm_extis well-structured and correctly implements various traits and conversion methods for CosmWasm extensions.
127-147: LGTM!The function
get_type_urlis well-implemented and correctly handles various cases for extracting the type URL from attributes.
149-185: LGTM!The function
get_query_attrsis well-implemented and correctly uses the custom matcher to extract query attributes.
188-192: LGTM!The function
get_attris simple and correctly retrieves the specified attribute from a list of attributes.
194-197: LGTM!The function
proto_message_attr_erroris well-implemented and correctly generates a compile error for invalidproto_messageattributes.
199-205: LGTM!The function
proto_query_attr_erroris well-implemented and correctly generates a compile error for invalidproto_queryattributes.
maxrobot
force-pushed
the
f/injective-tooling
branch
from
b3990f7 to
294da57
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
packages/injective-std/src/types/injective/peggy/v1.rs (1)
1311-1311: The renaming of the struct field has not been fully propagated.The field
batch_feesin theQueryBatchFeeResponsestruct has been renamed tobatchFees, but there are still references to the old field namebatch_feesin the codebase. Ensure that all references are updated to match the new naming convention.
packages/injective-std/src/types/injective/peggy/v1.rs: Functionbatch_feesstill uses the old field name.#!/bin/bash # Description: Verify all instances of the old and new field names. # Test: Search for the usage of both batch_fees and batchFees. rg --type rust 'batch_fees' rg --type rust 'batchFees'Analysis chain
Verify the impact of renaming the struct field.
The field
batch_feesin theQueryBatchFeeResponsestruct has been renamed tobatchFees. Ensure that all references to this field in the codebase are updated to match the new naming convention.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the references to the renamed struct field. # Test: Search for the usage of batchFees. Expect: No references to the old field name. rg --type rust 'batch_fees'Length of output: 170
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (31)
- packages/injective-protobuf/src/proto/mod.rs (1 hunks)
- packages/injective-std-derive/src/lib.rs (1 hunks)
- packages/injective-std/Cargo.toml (1 hunks)
- packages/injective-std/src/types/cosmos/auth/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/auth/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/authz/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/authz/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/bank/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/bank/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/node/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/query/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/distribution/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/distribution/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/feegrant/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/feegrant/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/params/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/params/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/staking/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmwasm/wasm/v1.rs (1 hunks)
- packages/injective-std/src/types/injective/auction/v1beta1.rs (2 hunks)
- packages/injective-std/src/types/injective/exchange/v1beta1.rs (15 hunks)
- packages/injective-std/src/types/injective/insurance/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/oracle/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/peggy/v1.rs (2 hunks)
- packages/injective-std/src/types/injective/permissions/v1beta1.rs (2 hunks)
- packages/injective-std/src/types/injective/tokenfactory/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/wasmx/v1.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/injective-protobuf/src/proto/mod.rs
Files skipped from review as they are similar to previous changes (3)
- packages/injective-std-derive/src/lib.rs
- packages/injective-std/Cargo.toml
- packages/injective-std/src/types/cosmos/base/v1beta1.rs
Additional context used
GitHub Check: Lints
packages/injective-std/src/types/injective/auction/v1beta1.rs
[failure] 176-176:
structure fieldauctionRoundshould have a snake case name
[failure] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[failure] 186-186:
structure fieldhighestBiddershould have a snake case name
[failure] 189-189:
structure fieldhighestBidAmountshould have a snake case namepackages/injective-std/src/types/injective/exchange/v1beta1.rs
[failure] 332-332:
structure fieldisPerpetualshould have a snake case name
[failure] 816-816:
structure fieldisReduceOnlyshould have a snake case name
[failure] 886-886:
structure fieldisLongshould have a snake case name
[failure] 905-905:
structure fieldisBuyshould have a snake case name
[failure] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[failure] 1472-1472:
methodexecutionTypeshould have a snake case name
GitHub Check: Test Suite
packages/injective-std/src/types/injective/auction/v1beta1.rs
[warning] 176-176:
structure fieldauctionRoundshould have a snake case name
[warning] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[warning] 186-186:
structure fieldhighestBiddershould have a snake case name
[warning] 189-189:
structure fieldhighestBidAmountshould have a snake case namepackages/injective-std/src/types/injective/exchange/v1beta1.rs
[warning] 332-332:
structure fieldisPerpetualshould have a snake case name
[warning] 816-816:
structure fieldisReduceOnlyshould have a snake case name
[warning] 886-886:
structure fieldisLongshould have a snake case name
[warning] 905-905:
structure fieldisBuyshould have a snake case name
[warning] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[warning] 1472-1472:
methodexecutionTypeshould have a snake case name
Additional comments not posted (71)
packages/injective-std/src/types/cosmos/authz/module/v1.rs (1)
1-1: Verify the new import path.Ensure that the
injective_std_derive::CosmwasmExtpath is correct and that the new macro provides the expected functionality.Verification successful
The import path
injective_std_derive::CosmwasmExtis correct and the macro is used as expected.
- The
CosmwasmExtmacro is defined and used extensively in the codebase.- The import path
injective_std_derive::CosmwasmExtis valid and referenced in multiple files.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate is correctly imported and used. # Test: Search for the `injective_std_derive` crate. Expect: The crate should be present in the dependencies. rg --type toml 'injective_std_derive'Length of output: 37
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate is correctly imported and used. # 1. Search for the `injective_std_derive` crate in all Cargo.toml files. echo "Searching for injective_std_derive in Cargo.toml files..." rg --type toml 'injective_std_derive' --glob '**/Cargo.toml' # 2. Search for the definition of the `CosmwasmExt` macro within the `injective_std_derive` crate. echo "Searching for the definition of the CosmwasmExt macro..." rg 'macro_rules! CosmwasmExt' # 3. Check the usage of the `CosmwasmExt` macro in the codebase. echo "Searching for the usage of the CosmwasmExt macro..." rg 'CosmwasmExt' --glob '**/*.rs'Length of output: 210158
packages/injective-std/src/types/cosmos/params/module/v1.rs (1)
1-1: Verify the new import path.Ensure that the
injective_std_derive::CosmwasmExtpath is correct and that the new macro provides the expected functionality.Verification successful
Verified the new import path.
The
injective_std_derive::CosmwasmExtpath is correct and the necessary dependencies are listed in theCargo.tomlfile.
injective-std-deriveis listed inpackages/injective-std/Cargo.toml.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate is correctly imported and used. # Test: Search for the `injective_std_derive` crate. Expect: The crate should be present in the dependencies. rg --type toml 'injective_std_derive'Length of output: 37
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate is correctly imported and used. # Step 1: Search for the `injective_std_derive` crate in all `Cargo.toml` files. rg 'injective_std_derive' --glob '**/Cargo.toml' # Step 2: Check if `CosmwasmExt` is defined within the `injective_std_derive` crate. fd -t f -e rs | xargs rg 'CosmwasmExt' # Step 3: Verify that `CosmwasmExt` is used in the codebase. rg 'CosmwasmExt' --glob '**/*.rs'Length of output: 419463
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate is correctly listed in the dependencies. # Search for any mention of `injective_std_derive` in all `Cargo.toml` files. rg 'injective_std_derive' --glob '**/Cargo.toml'Length of output: 48
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive` crate or any similar pattern is correctly listed in the dependencies. # Search for any mention of `injective_std_derive` or similar patterns in all `Cargo.toml` files. rg 'injective[-_]std[-_]derive' --glob '**/Cargo.toml'Length of output: 214
packages/injective-std/src/types/cosmos/feegrant/module/v1.rs (1)
1-1: Verify the new import path.Ensure that the
injective_std_derive::CosmwasmExtpath is correct and that the new macro provides the expected functionality.packages/injective-std/src/types/cosmos/distribution/module/v1.rs (1)
1-1: LGTM! But verify the impact of the new dependency.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new dependency does not introduce any breaking changes or unexpected behavior.packages/injective-std/src/types/cosmos/gov/module/v1.rs (1)
1-1: LGTM! But verify the impact of the new dependency.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new dependency does not introduce any breaking changes or unexpected behavior.packages/injective-std/src/types/cosmos/bank/module/v1.rs (1)
1-1: LGTM! But verify the impact of the new dependency.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new dependency does not introduce any breaking changes or unexpected behavior.packages/injective-std/src/types/cosmos/auth/module/v1.rs (1)
1-1: Update import statement to useinjective_std_derive::CosmwasmExt.The import statement has been updated to reflect the new dependency, ensuring that the
CosmwasmExtderive macro is sourced frominjective_std_deriveinstead ofosmosis_std_derive.packages/injective-std/src/types/cosmos/base/node/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive::CosmwasmExt.The import statement has been updated to reflect the new dependency, ensuring that the
CosmwasmExtderive macro is sourced frominjective_std_deriveinstead ofosmosis_std_derive.packages/injective-std/src/types/cosmos/base/query/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive::CosmwasmExt.The import statement has been updated to reflect the new dependency, ensuring that the
CosmwasmExtderive macro is sourced frominjective_std_deriveinstead ofosmosis_std_derive.packages/injective-std/src/types/cosmos/params/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same functionality as the old one.packages/injective-std/src/types/cosmos/feegrant/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same functionality as the old one.packages/injective-std/src/types/injective/auction/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same functionality as the old one.packages/injective-std/src/types/cosmos/authz/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_deriveinstead ofosmosis_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same or enhanced functionality as the previous one.Verification successful
Import statement correctly updated
The import statement has been correctly updated to use
injective_std_derive::CosmwasmExt. TheCosmwasmExtmacro is defined and used extensively within the codebase, confirming its functionality.
packages/injective-std-derive/src/lib.rs: Definition ofCosmwasmExtmacro.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg --type rust --pattern 'macro_rules! CosmwasmExt' --files-with-matchesLength of output: 486
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg 'macro_rules! CosmwasmExt' --type rustLength of output: 43
Script:
#!/bin/bash # Description: Verify the presence and usage of `CosmwasmExt` in the `injective_std_derive` crate. # Test: Search for any occurrence of `CosmwasmExt` in the codebase. rg 'CosmwasmExt' --type rustLength of output: 209699
packages/injective-std/src/types/injective/tokenfactory/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_deriveinstead ofosmosis_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same or enhanced functionality as the previous one.Verification successful
Import statement update verified successfully.
The import statement has been correctly updated to use
injective_std_derive::CosmwasmExt. TheCosmwasmExtmacro is defined in theinjective_std_derivecrate and is extensively used across the codebase, ensuring it provides the required functionality.
injective-std/src/types/injective/tokenfactory/v1beta1.rsinjective-std/src/types/injective/auction/v1beta1.rsinjective-std/src/types/injective/peggy/v1.rsinjective-std/src/types/cosmwasm/wasm/v1.rsinjective-std/src/types/cosmos/params/v1beta1.rsinjective-std/src/types/cosmos/distribution/v1beta1.rsinjective-std/src/types/cosmos/gov/v1beta1.rsinjective-std/src/types/cosmos/base/v1beta1.rsinjective-std/src/types/cosmos/authz/v1beta1.rsinjective-std/src/types/injective/permissions/v1beta1.rsinjective-std/src/types/cosmos/bank/v1beta1.rsinjective-std/src/types/injective/oracle/v1beta1.rsinjective-std/src/types/injective/insurance/v1beta1.rsinjective-std/src/types/injective/exchange/v1beta1.rsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg --type rust --pattern 'macro_rules! CosmwasmExt' --files-with-matchesLength of output: 486
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg 'macro_rules! CosmwasmExt' # Test: Search for the usage of the `CosmwasmExt` macro in the codebase. rg 'CosmwasmExt'Length of output: 209719
packages/injective-std/src/types/cosmos/auth/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_deriveinstead ofosmosis_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that the new library provides the same or enhanced functionality as the previous one.Verification successful
The
CosmwasmExtproc-macro derive frominjective_std_deriveis correctly imported and used.
- The
CosmwasmExtproc-macro derive is defined and used extensively throughout the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg --type rust --pattern 'macro_rules! CosmwasmExt' --files-with-matchesLength of output: 486
Script:
#!/bin/bash # Description: Verify that the `injective_std_derive::CosmwasmExt` macro is correctly imported and used. # Test: Search for the definition of the `CosmwasmExt` macro in the `injective_std_derive` crate. rg 'macro_rules! CosmwasmExt' --type rustLength of output: 43
Script:
#!/bin/bash # Description: Verify if any macros are defined in the `injective_std_derive` crate and check the usage of `CosmwasmExt` in the codebase. # Test 1: Search for any macro definitions in the `injective_std_derive` crate. rg 'macro_rules!' --type rust --glob '*/injective_std_derive/*' # Test 2: Search for the usage of `CosmwasmExt` in the codebase. rg 'CosmwasmExt' --type rustLength of output: 209914
packages/injective-std/src/types/injective/permissions/v1beta1.rs (2)
1-1: Verify the correctness of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality asosmosis_std_derive::CosmwasmExt.
326-326: Verify the correctness of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality asosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/injective/wasmx/v1.rs (1)
1-1: Verify the correctness of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality asosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/injective/insurance/v1beta1.rs (1)
1-1: Verify the correctness of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality asosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/cosmos/gov/v1beta1.rs (1)
1-1: LGTM! But verify the usage ofCosmwasmExtin the codebase.The import statement change is approved.
However, ensure that all usages of
CosmwasmExtare compatible withinjective_std_derive.packages/injective-std/src/types/cosmos/staking/v1beta1.rs (1)
1-1: LGTM! But verify the usage ofCosmwasmExtin the codebase.The import statement change is approved.
However, ensure that all usages of
CosmwasmExtare compatible withinjective_std_derive.packages/injective-std/src/types/cosmos/bank/v1beta1.rs (1)
1-1: Verify the correctness of the new import.Ensure that
injective_std_derive::CosmwasmExtis correctly defined and used within the codebase.Verification successful
The import statement is correct and integrates properly with the rest of the code.
The
CosmwasmExtmacro is correctly defined in theinjective_std_derivecrate and is used appropriately in thepackages/injective-std/src/types/cosmos/bank/v1beta1.rsfile.
- The
CosmwasmExtmacro is defined inpackages/injective-std-derive/src/lib.rs.- The macro is applied to multiple struct definitions in the target file.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and correctness of the new import. # Test: Search for the definition of CosmwasmExt in injective_std_derive. rg --type rust 'CosmwasmExt' --glob 'packages/injective-std-derive/src/**/*.rs'Length of output: 194
Script:
#!/bin/bash # Description: Verify the usage of CosmwasmExt in the target file. # Test: Search for the usage of CosmwasmExt in the target file. rg 'CosmwasmExt' --glob 'packages/injective-std/src/types/cosmos/bank/v1beta1.rs'Length of output: 8869
packages/injective-std/src/types/cosmos/distribution/v1beta1.rs (1)
1-1: Verify the impact of the import change.The import statement has been changed from
osmosis_std_derive::CosmwasmExttoinjective_std_derive::CosmwasmExt. Ensure that the new dependency is compatible and functions as expected with the existing codebase.packages/injective-std/src/types/cosmos/gov/v1.rs (1)
1-1: Verify the impact of the import change.The import statement has been changed from
osmosis_std_derive::CosmwasmExttoinjective_std_derive::CosmwasmExt. Ensure that the new dependency is compatible and functions as expected with the existing codebase.packages/injective-std/src/types/injective/oracle/v1beta1.rs (30)
Line range hint
4-8:
LGTM!The
Paramsstruct is correctly defined.
Line range hint
9-16:
LGTM!The
OracleInfostruct is correctly defined.
Line range hint
17-25:
LGTM!The
ChainlinkPriceStatestruct is correctly defined.
Line range hint
26-36:
LGTM!The
BandPriceStatestruct is correctly defined.
Line range hint
37-45:
LGTM!The
PriceFeedStatestruct is correctly defined.
Line range hint
46-51:
LGTM!The
ProviderInfostruct is correctly defined.
Line range hint
52-58:
LGTM!The
ProviderStatestruct is correctly defined.
Line range hint
59-64:
LGTM!The
ProviderPriceStatestruct is correctly defined.
Line range hint
65-69:
LGTM!The
PriceFeedInfostruct is correctly defined.
Line range hint
70-73:
LGTM!The
PriceFeedPricestruct is correctly defined.
Line range hint
74-85:
LGTM!The
CoinbasePriceStatestruct is correctly defined.
Line range hint
86-95:
LGTM!The
StorkPriceStatestruct is correctly defined.
Line range hint
96-102:
LGTM!The
PriceStatestruct is correctly defined.
Line range hint
103-113:
LGTM!The
PythPriceStatestruct is correctly defined.
Line range hint
114-131:
LGTM!The
BandOracleRequeststruct is correctly defined.
Line range hint
132-145:
LGTM!The
BandIbcParamsstruct is correctly defined.
Line range hint
146-152:
LGTM!The
SymbolPriceTimestampstruct is correctly defined.
Line range hint
153-156:
LGTM!The
LastPriceTimestampsstruct is correctly defined.
Line range hint
157-164:
LGTM!The
PriceRecordsstruct is correctly defined.
Line range hint
165-169:
LGTM!The
PriceRecordstruct is correctly defined.
Line range hint
170-198:
LGTM!The
OracleTypeenum is correctly defined.
Line range hint
199-205:
LGTM!The
SetChainlinkPriceEventstruct is correctly defined.
Line range hint
206-214:
LGTM!The
SetBandPriceEventstruct is correctly defined.
Line range hint
215-226:
LGTM!The
SetBandIbcPriceEventstruct is correctly defined.
Line range hint
227-232:
LGTM!The
EventBandIbcAckSuccessstruct is correctly defined.
Line range hint
233-238:
LGTM!The
EventBandIbcAckErrorstruct is correctly defined.
Line range hint
239-243:
LGTM!The
EventBandIbcResponseTimeoutstruct is correctly defined.
Line range hint
244-250:
LGTM!The
SetPriceFeedPriceEventstruct is correctly defined.
Line range hint
251-257:
LGTM!The
SetProviderPriceEventstruct is correctly defined.
1-1: Verify the new dependency.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality asosmosis_std_derive::CosmwasmExtand does not introduce any issues.Verification successful
Verified the new dependency.
The
injective_std_derive::CosmwasmExtprovides the required functionality and is correctly implemented across the codebase. The change fromosmosis_std_derive::CosmwasmExttoinjective_std_derive::CosmwasmExtdoes not introduce any issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the functionality provided by the new dependency. # Test: Search for the definition of `CosmwasmExt` in the `injective_std_derive` crate. rg --type rust 'pub trait CosmwasmExt' --context 10Length of output: 53
Script:
#!/bin/bash # Description: Verify the functionality provided by the new dependency. # Test 1: Search for all public traits in the `injective_std_derive` crate. rg --type rust 'pub trait' --context 10 # Test 2: Search for all occurrences of `CosmwasmExt` in the codebase to verify its usage. rg 'CosmwasmExt'Length of output: 230370
packages/injective-std/src/types/injective/peggy/v1.rs (1)
1-1: Verify the impact of changing the import source.The import statement has been changed from
osmosis_std_derivetoinjective_std_derive. Ensure that all functionalities provided byCosmwasmExtfrom the new source are compatible with the existing code.Verification successful
Verified the impact of changing the import source.
The import statement has been changed from
osmosis_std_derivetoinjective_std_derive. The search results indicate thatCosmwasmExtis consistently imported frominjective_std_deriveacross the codebase, and there are no compatibility issues found.
- All instances of
CosmwasmExtare correctly usinginjective_std_derive.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of CosmwasmExt from the new source. # Test: Search for the usage of CosmwasmExt. Expect: No compatibility issues. rg --type rust 'CosmwasmExt'Length of output: 209699
packages/injective-std/src/types/cosmwasm/wasm/v1.rs (1)
1-1: Verify the new import path.Ensure that the
injective_std_derive::CosmwasmExtpath is correct and that theinjective_std_derivecrate is included in the project's dependencies.Verification successful
Verified the new import path.
The
injective_std_derive::CosmwasmExtpath is correct and theinjective_std_derivecrate is properly included in the project's dependencies.
packages/injective-std-derive/src/lib.rs: Definition ofCosmwasmExt.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new import path for `injective_std_derive::CosmwasmExt`. # Test: Search for the `injective_std_derive` crate in the project's dependencies. Expect: The crate is listed as a dependency. rg --type toml 'injective_std_derive'Length of output: 37
Script:
#!/bin/bash # Description: Verify the new import path for `injective_std_derive::CosmwasmExt`. # Test: Search for the `injective_std_derive` crate in the project's dependencies across all relevant files. rg --type toml 'injective_std_derive' . # Test: Search for the `CosmwasmExt` within the `injective_std_derive` crate to ensure it exists. rg 'CosmwasmExt' $(fd -e rs)Length of output: 217986
packages/injective-std/src/types/injective/exchange/v1beta1.rs (15)
1-1: LGTM!The import statement has been correctly updated to use
injective_std_derive::CosmwasmExt.
332-332: Consider using snake_case for struct fields.The field
isPerpetualshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
Tools
GitHub Check: Lints
[failure] 332-332:
structure fieldisPerpetualshould have a snake case nameGitHub Check: Test Suite
[warning] 332-332:
structure fieldisPerpetualshould have a snake case name
816-816: Consider using snake_case for struct fields.The field
isReduceOnlyshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
Tools
GitHub Check: Lints
[failure] 816-816:
structure fieldisReduceOnlyshould have a snake case nameGitHub Check: Test Suite
[warning] 816-816:
structure fieldisReduceOnlyshould have a snake case name
886-886: Consider using snake_case for struct fields.The field
isLongshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
Tools
GitHub Check: Lints
[failure] 886-886:
structure fieldisLongshould have a snake case nameGitHub Check: Test Suite
[warning] 886-886:
structure fieldisLongshould have a snake case name
905-905: Consider using snake_case for struct fields.The field
isBuyshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
Tools
GitHub Check: Lints
[failure] 905-905:
structure fieldisBuyshould have a snake case nameGitHub Check: Test Suite
[warning] 905-905:
structure fieldisBuyshould have a snake case name
1472-1472: Consider using snake_case for struct fields.The field
executionTypeshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
Tools
GitHub Check: Lints
[failure] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[failure] 1472-1472:
methodexecutionTypeshould have a snake case nameGitHub Check: Test Suite
[warning] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[warning] 1472-1472:
methodexecutionTypeshould have a snake case name
1495-1495: Consider using snake_case for struct fields.The field
executionTypeshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
1707-1707: Consider using snake_case for struct fields.The field
isLimitCancelshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
1758-1758: Consider using snake_case for struct fields.The field
isLimitCancelshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
1772-1772: Consider using snake_case for struct fields.The field
isLimitTriggershould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
3180-3180: Consider using snake_case for struct fields.The field
isBuySideshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
3193-3193: Consider using snake_case for struct fields.The field
isBuySideshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
3352-3352: Consider using snake_case for struct fields.The field
exchangeTypeshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
4861-4861: LGTM!The import statement has been correctly updated to use
injective_std_derive::CosmwasmExt.
5621-5628: Consider using snake_case for struct fields.The fields
triggerPrice,isBuy, andisLimitshould ideally follow snake_case naming conventions as per Rust guidelines.Ensure that this naming convention change is consistent across the codebase and does not introduce any issues.
| pub auctionRound: u64, | ||
| /// auctionClosingTime describes auction close time for the round | ||
| #[prost(int64, tag = "3")] | ||
| #[serde( | ||
| serialize_with = "crate::serde::as_str::serialize", | ||
| deserialize_with = "crate::serde::as_str::deserialize" | ||
| )] | ||
| pub auction_closing_time: i64, | ||
| pub auctionClosingTime: i64, | ||
| /// highestBidder describes highest bidder on current round | ||
| #[prost(string, tag = "4")] | ||
| pub highest_bidder: ::prost::alloc::string::String, | ||
| pub highestBidder: ::prost::alloc::string::String, | ||
| /// highestBidAmount describes highest bid amount on current round | ||
| #[prost(string, tag = "5")] | ||
| pub highest_bid_amount: ::prost::alloc::string::String, | ||
| pub highestBidAmount: ::prost::alloc::string::String, |
There was a problem hiding this comment.
Revert field names to snake_case.
The field names in the QueryCurrentAuctionBasketResponse struct have been changed to camelCase. However, static analysis hints suggest that they should remain in snake_case to follow Rust naming conventions.
- pub auctionRound: u64,
+ pub auction_round: u64,
- pub auctionClosingTime: i64,
+ pub auction_closing_time: i64,
- pub highestBidder: ::prost::alloc::string::String,
+ pub highest_bidder: ::prost::alloc::string::String,
- pub highestBidAmount: ::prost::alloc::string::String,
+ pub highest_bid_amount: ::prost::alloc::string::String,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pub auctionRound: u64, | |
| /// auctionClosingTime describes auction close time for the round | |
| #[prost(int64, tag = "3")] | |
| #[serde( | |
| serialize_with = "crate::serde::as_str::serialize", | |
| deserialize_with = "crate::serde::as_str::deserialize" | |
| )] | |
| pub auction_closing_time: i64, | |
| pub auctionClosingTime: i64, | |
| /// highestBidder describes highest bidder on current round | |
| #[prost(string, tag = "4")] | |
| pub highest_bidder: ::prost::alloc::string::String, | |
| pub highestBidder: ::prost::alloc::string::String, | |
| /// highestBidAmount describes highest bid amount on current round | |
| #[prost(string, tag = "5")] | |
| pub highest_bid_amount: ::prost::alloc::string::String, | |
| pub highestBidAmount: ::prost::alloc::string::String, | |
| pub auction_round: u64, | |
| /// auctionClosingTime describes auction close time for the round | |
| #[prost(int64, tag = "3")] | |
| #[serde( | |
| serialize_with = "crate::serde::as_str::serialize", | |
| deserialize_with = "crate::serde::as_str::deserialize" | |
| )] | |
| pub auction_closing_time: i64, | |
| /// highestBidder describes highest bidder on current round | |
| #[prost(string, tag = "4")] | |
| pub highest_bidder: ::prost::alloc::string::String, | |
| /// highestBidAmount describes highest bid amount on current round | |
| #[prost(string, tag = "5")] | |
| pub highest_bid_amount: ::prost::alloc::string::String, |
Tools
GitHub Check: Lints
[failure] 176-176:
structure fieldauctionRoundshould have a snake case name
[failure] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[failure] 186-186:
structure fieldhighestBiddershould have a snake case name
[failure] 189-189:
structure fieldhighestBidAmountshould have a snake case name
GitHub Check: Test Suite
[warning] 176-176:
structure fieldauctionRoundshould have a snake case name
[warning] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[warning] 186-186:
structure fieldhighestBiddershould have a snake case name
[warning] 189-189:
structure fieldhighestBidAmountshould have a snake case name
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
packages/injective-std/src/types/injective/peggy/v1.rs (1)
1311-1311: Update the remaining instance ofbatch_feestobatchFeesin the function definition.The field
batch_feesin theQueryBatchFeeResponsestruct has been renamed tobatchFees. However, the old field namebatch_feesis still used in a function definition. Please update this instance to ensure consistency and prevent potential issues.
packages/injective-std/src/types/injective/peggy/v1.rs:pub fn batch_fees(&self) -> Result<QueryBatchFeeResponse, cosmwasm_std::StdError>Analysis chain
Verify the usage of the new field name and update serialization/deserialization processes.
The field
batch_feesinQueryBatchFeeResponsestruct has been renamed tobatchFees. Ensure that the new field name is correctly used throughout the codebase and update serialization and deserialization processes accordingly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new field name and update serialization/deserialization processes. # Test: Search for the usage of `batchFees`. Expect: No errors or issues with serialization/deserialization. rg --type rust -A 5 $'batchFees'Length of output: 703
Script:
#!/bin/bash # Search for the usage of `batchFees` throughout the codebase to ensure consistency. rg --type rust 'batchFees' # Check for the usage of the old field name `batch_fees` to ensure it has been fully replaced. rg --type rust 'batch_fees'Length of output: 308
Script:
#!/bin/bash # Search for all instances of `batch_fees` in the codebase to ensure they are updated to `batchFees`. rg --type rust 'batch_fees'Length of output: 170
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (31)
- packages/injective-protobuf/src/proto/mod.rs (1 hunks)
- packages/injective-std-derive/src/lib.rs (1 hunks)
- packages/injective-std/Cargo.toml (1 hunks)
- packages/injective-std/src/types/cosmos/auth/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/auth/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/authz/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/authz/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/bank/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/bank/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/node/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/query/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/base/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/distribution/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/distribution/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/feegrant/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/feegrant/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/gov/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/params/module/v1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/params/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmos/staking/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/cosmwasm/wasm/v1.rs (1 hunks)
- packages/injective-std/src/types/injective/auction/v1beta1.rs (2 hunks)
- packages/injective-std/src/types/injective/exchange/v1beta1.rs (15 hunks)
- packages/injective-std/src/types/injective/insurance/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/oracle/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/peggy/v1.rs (2 hunks)
- packages/injective-std/src/types/injective/permissions/v1beta1.rs (2 hunks)
- packages/injective-std/src/types/injective/tokenfactory/v1beta1.rs (1 hunks)
- packages/injective-std/src/types/injective/wasmx/v1.rs (1 hunks)
Files skipped from review due to trivial changes (9)
- packages/injective-protobuf/src/proto/mod.rs
- packages/injective-std/src/types/cosmos/authz/module/v1.rs
- packages/injective-std/src/types/cosmos/gov/module/v1.rs
- packages/injective-std/src/types/cosmos/gov/v1beta1.rs
- packages/injective-std/src/types/cosmos/staking/v1beta1.rs
- packages/injective-std/src/types/cosmwasm/wasm/v1.rs
- packages/injective-std/src/types/injective/oracle/v1beta1.rs
- packages/injective-std/src/types/injective/permissions/v1beta1.rs
- packages/injective-std/src/types/injective/tokenfactory/v1beta1.rs
Files skipped from review as they are similar to previous changes (3)
- packages/injective-std-derive/src/lib.rs
- packages/injective-std/Cargo.toml
- packages/injective-std/src/types/cosmos/base/v1beta1.rs
Additional context used
GitHub Check: Lints
packages/injective-std/src/types/injective/auction/v1beta1.rs
[failure] 176-176:
structure fieldauctionRoundshould have a snake case name
[failure] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[failure] 186-186:
structure fieldhighestBiddershould have a snake case name
[failure] 189-189:
structure fieldhighestBidAmountshould have a snake case namepackages/injective-std/src/types/injective/exchange/v1beta1.rs
[failure] 332-332:
structure fieldisPerpetualshould have a snake case name
[failure] 816-816:
structure fieldisReduceOnlyshould have a snake case name
[failure] 886-886:
structure fieldisLongshould have a snake case name
[failure] 905-905:
structure fieldisBuyshould have a snake case name
[failure] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[failure] 1472-1472:
methodexecutionTypeshould have a snake case name
GitHub Check: Test Suite
packages/injective-std/src/types/injective/auction/v1beta1.rs
[warning] 176-176:
structure fieldauctionRoundshould have a snake case name
[warning] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[warning] 186-186:
structure fieldhighestBiddershould have a snake case name
[warning] 189-189:
structure fieldhighestBidAmountshould have a snake case namepackages/injective-std/src/types/injective/exchange/v1beta1.rs
[warning] 332-332:
structure fieldisPerpetualshould have a snake case name
[warning] 816-816:
structure fieldisReduceOnlyshould have a snake case name
[warning] 886-886:
structure fieldisLongshould have a snake case name
[warning] 905-905:
structure fieldisBuyshould have a snake case name
[warning] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[warning] 1472-1472:
methodexecutionTypeshould have a snake case name
Additional comments not posted (36)
packages/injective-std/src/types/cosmos/params/module/v1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that the new macro provides the same or enhanced functionality as the previous one.packages/injective-std/src/types/cosmos/feegrant/module/v1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that the new macro provides the same or enhanced functionality as the previous one.packages/injective-std/src/types/cosmos/distribution/module/v1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that the new macro provides the same or enhanced functionality as the previous one.packages/injective-std/src/types/cosmos/bank/module/v1.rs (2)
Line range hint
2-14: LGTM!The
Modulestruct definition appears to be correct and follows standard Rust conventions.
1-1: Verify the impact of the new dependency.The import statement has been changed from
osmosis_std_derivetoinjective_std_derive. Ensure that the new dependency provides the required functionality and does not introduce any breaking changes.packages/injective-std/src/types/cosmos/auth/module/v1.rs (2)
Line range hint
2-22: LGTM!The
ModuleandModuleAccountPermissionstruct definitions appear to be correct and follow standard Rust conventions.
1-1: Verify the impact of the new dependency.The import statement has been changed from
osmosis_std_derivetoinjective_std_derive. Ensure that the new dependency provides the required functionality and does not introduce any breaking changes.packages/injective-std/src/types/cosmos/base/node/v1beta1.rs (2)
Line range hint
2-45: LGTM!The
ConfigRequest,ConfigResponse,StatusRequest, andStatusResponsestruct definitions appear to be correct and follow standard Rust conventions.
1-1: Verify the impact of the new dependency.The import statement has been changed from
osmosis_std_derivetoinjective_std_derive. Ensure that the new dependency provides the required functionality and does not introduce any breaking changes.packages/injective-std/src/types/cosmos/base/query/v1beta1.rs (1)
1-1: Updated dependency toinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that this change does not introduce any compatibility issues with the rest of the codebase.packages/injective-std/src/types/cosmos/params/v1beta1.rs (1)
1-1: Updated dependency toinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that this change does not introduce any compatibility issues with the rest of the codebase.packages/injective-std/src/types/cosmos/feegrant/v1beta1.rs (1)
1-1: Updated dependency toinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExt. Ensure that this change does not introduce any compatibility issues with the rest of the codebase.packages/injective-std/src/types/injective/auction/v1beta1.rs (1)
1-1: Verify compatibility of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality compared toosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/cosmos/authz/v1beta1.rs (1)
1-1: Verify compatibility of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality compared toosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/cosmos/auth/v1beta1.rs (1)
1-1: Verify compatibility of the new import.Ensure that
injective_std_derive::CosmwasmExtprovides the same or improved functionality compared toosmosis_std_derive::CosmwasmExt.packages/injective-std/src/types/injective/peggy/v1.rs (1)
1-1: Verify the compatibility and integration of the new dependency.The import path for
CosmwasmExtwas altered fromosmosis_std_derivetoinjective_std_derive. Ensure that the new dependency is compatible and correctly integrated.packages/injective-std/src/types/injective/exchange/v1beta1.rs (15)
Line range hint
1-5:
LGTM!The introduction of
injective_std_derive::CosmwasmExtis appropriate and aligns with the PR's objective.
Line range hint
332-336:
LGTM!The renaming of
is_perpetualtoisPerpetualis consistent with camelCase naming conventions.Tools
GitHub Check: Lints
[failure] 332-332:
structure fieldisPerpetualshould have a snake case nameGitHub Check: Test Suite
[warning] 332-332:
structure fieldisPerpetualshould have a snake case name
Line range hint
816-820:
LGTM!The renaming of
is_reduce_onlytoisReduceOnlyis consistent with camelCase naming conventions.Tools
GitHub Check: Lints
[failure] 816-816:
structure fieldisReduceOnlyshould have a snake case nameGitHub Check: Test Suite
[warning] 816-816:
structure fieldisReduceOnlyshould have a snake case name
Line range hint
886-890:
LGTM!The renaming of
is_longtoisLongis consistent with camelCase naming conventions.Tools
GitHub Check: Lints
[failure] 886-886:
structure fieldisLongshould have a snake case nameGitHub Check: Test Suite
[warning] 886-886:
structure fieldisLongshould have a snake case name
Line range hint
905-909:
LGTM!The renaming of
is_buytoisBuyis consistent with camelCase naming conventions.Tools
GitHub Check: Lints
[failure] 905-905:
structure fieldisBuyshould have a snake case nameGitHub Check: Test Suite
[warning] 905-905:
structure fieldisBuyshould have a snake case name
Line range hint
1472-1476:
LGTM!The renaming of
execution_typetoexecutionTypeis consistent with camelCase naming conventions.Tools
GitHub Check: Lints
[failure] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[failure] 1472-1472:
methodexecutionTypeshould have a snake case nameGitHub Check: Test Suite
[warning] 1472-1472:
structure fieldexecutionTypeshould have a snake case name
[warning] 1472-1472:
methodexecutionTypeshould have a snake case name
Line range hint
1495-1499:
LGTM!The renaming of
execution_typetoexecutionTypeis consistent with camelCase naming conventions.
Line range hint
1707-1711:
LGTM!The renaming of
is_limit_canceltoisLimitCancelis consistent with camelCase naming conventions.
Line range hint
1758-1762:
LGTM!The renaming of
is_limit_canceltoisLimitCancelis consistent with camelCase naming conventions.
Line range hint
1772-1776:
LGTM!The renaming of
is_limit_triggertoisLimitTriggeris consistent with camelCase naming conventions.
Line range hint
3180-3184:
LGTM!The renaming of
is_buy_sidetoisBuySideis consistent with camelCase naming conventions.
Line range hint
3193-3197:
LGTM!The renaming of
is_buy_sidetoisBuySideis consistent with camelCase naming conventions.
Line range hint
3352-3356:
LGTM!The renaming of
exchange_typetoexchangeTypeis consistent with camelCase naming conventions.
Line range hint
4861-4866:
LGTM!The introduction of
injective_std_derive::CosmwasmExtin thefull_derivative_marketmodule is appropriate and aligns with the PR's objective.
5621-5629: LGTM!The renaming of
trigger_price,is_buy, andis_limittotriggerPrice,isBuy, andisLimitrespectively is consistent with camelCase naming conventions.packages/injective-std/src/types/injective/wasmx/v1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that this change aligns with the overall objectives and does not introduce any unintended side effects.packages/injective-std/src/types/injective/insurance/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that this change aligns with the overall objectives and does not introduce any unintended side effects.packages/injective-std/src/types/cosmos/bank/v1beta1.rs (1)
1-1: Update import statement to useinjective_std_derive.The import statement has been updated to use
injective_std_derive::CosmwasmExtinstead ofosmosis_std_derive::CosmwasmExt. Ensure that this change aligns with the overall objectives and does not introduce any unintended side effects.packages/injective-std/src/types/cosmos/distribution/v1beta1.rs (1)
1-1: Verify the compatibility and functionality of the new dependency.The import statement has been changed from
osmosis_std_derive::CosmwasmExttoinjective_std_derive::CosmwasmExt. Ensure that the new dependency provides the same or improved functionality without introducing any issues.packages/injective-std/src/types/cosmos/gov/v1.rs (1)
1-1: Verify the compatibility and functionality of the new dependency.The import statement has been changed from
osmosis_std_derive::CosmwasmExttoinjective_std_derive::CosmwasmExt. Ensure that the new dependency provides the same or improved functionality without introducing any issues.
| pub auctionRound: u64, | ||
| /// auctionClosingTime describes auction close time for the round | ||
| #[prost(int64, tag = "3")] | ||
| #[serde( | ||
| serialize_with = "crate::serde::as_str::serialize", | ||
| deserialize_with = "crate::serde::as_str::deserialize" | ||
| )] | ||
| pub auction_closing_time: i64, | ||
| pub auctionClosingTime: i64, | ||
| /// highestBidder describes highest bidder on current round | ||
| #[prost(string, tag = "4")] | ||
| pub highest_bidder: ::prost::alloc::string::String, | ||
| pub highestBidder: ::prost::alloc::string::String, | ||
| /// highestBidAmount describes highest bid amount on current round | ||
| #[prost(string, tag = "5")] | ||
| pub highest_bid_amount: ::prost::alloc::string::String, | ||
| pub highestBidAmount: ::prost::alloc::string::String, |
There was a problem hiding this comment.
Consider using snake_case for structure fields.
Static analysis tools suggest using snake_case for structure fields to align with Rust conventions.
- pub auctionRound: u64,
- pub auctionClosingTime: i64,
- pub highestBidder: ::prost::alloc::string::String,
- pub highestBidAmount: ::prost::alloc::string::String,
+ pub auction_round: u64,
+ pub auction_closing_time: i64,
+ pub highest_bidder: ::prost::alloc::string::String,
+ pub highest_bid_amount: ::prost::alloc::string::String,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pub auctionRound: u64, | |
| /// auctionClosingTime describes auction close time for the round | |
| #[prost(int64, tag = "3")] | |
| #[serde( | |
| serialize_with = "crate::serde::as_str::serialize", | |
| deserialize_with = "crate::serde::as_str::deserialize" | |
| )] | |
| pub auction_closing_time: i64, | |
| pub auctionClosingTime: i64, | |
| /// highestBidder describes highest bidder on current round | |
| #[prost(string, tag = "4")] | |
| pub highest_bidder: ::prost::alloc::string::String, | |
| pub highestBidder: ::prost::alloc::string::String, | |
| /// highestBidAmount describes highest bid amount on current round | |
| #[prost(string, tag = "5")] | |
| pub highest_bid_amount: ::prost::alloc::string::String, | |
| pub highestBidAmount: ::prost::alloc::string::String, | |
| pub auction_round: u64, | |
| /// auctionClosingTime describes auction close time for the round | |
| #[prost(int64, tag = "3")] | |
| #[serde( | |
| serialize_with = "crate::serde::as_str::serialize", | |
| deserialize_with = "crate::serde::as_str::deserialize" | |
| )] | |
| pub auction_closing_time: i64, | |
| /// highestBidder describes highest bidder on current round | |
| #[prost(string, tag = "4")] | |
| pub highest_bidder: ::prost::alloc::string::String, | |
| /// highestBidAmount describes highest bid amount on current round | |
| #[prost(string, tag = "5")] | |
| pub highest_bid_amount: ::prost::alloc::string::String, |
Tools
GitHub Check: Lints
[failure] 176-176:
structure fieldauctionRoundshould have a snake case name
[failure] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[failure] 186-186:
structure fieldhighestBiddershould have a snake case name
[failure] 189-189:
structure fieldhighestBidAmountshould have a snake case name
GitHub Check: Test Suite
[warning] 176-176:
structure fieldauctionRoundshould have a snake case name
[warning] 183-183:
structure fieldauctionClosingTimeshould have a snake case name
[warning] 186-186:
structure fieldhighestBiddershould have a snake case name
[warning] 189-189:
structure fieldhighestBidAmountshould have a snake case name
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/injective-std/src/types/injective/auction/mod.rs (1 hunks)
- packages/injective-std/src/types/injective/exchange/mod.rs (1 hunks)
- packages/injective-std/src/types/injective/peggy/mod.rs (1 hunks)
- packages/injective-std/src/types/injective/peggy/v1.rs (2 hunks)
Files skipped from review due to trivial changes (4)
- packages/injective-std/src/types/injective/auction/mod.rs
- packages/injective-std/src/types/injective/exchange/mod.rs
- packages/injective-std/src/types/injective/peggy/mod.rs
- packages/injective-std/src/types/injective/peggy/v1.rs
| } | ||
|
|
||
| #[proc_macro_derive(CosmwasmExt, attributes(proto_message, proto_query))] | ||
| pub fn derive_cosmwasm_ext(input: TokenStream) -> TokenStream { |
There was a problem hiding this comment.
brake into smaller functions could make sense
As discussed.
Summary by CodeRabbit
New Features
injective-std-derivepackage that provides procedural macros to streamline development with CosmWasm smart contracts.Bug Fixes
Documentation
injective-std-derivepackage to explain its purpose and usage, improving developer understanding.Tests
Style