Skip to content

Commit

Permalink
Add deselect selector to proxy
Browse files Browse the repository at this point in the history
Summary:
Issue fixed: #1105

- [x] All tests pass. Demo project builds and runs.
- [ ] ~~I added tests, an experiment, or detailed why my change isn't tested.~~
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.

Unable to add tests w/out hacking `UITouch` events on a collection view. Open to suggestions.
Closes #1108

Differential Revision: D7362200

Pulled By: rnystrom

fbshipit-source-id: fed640c2c017f0ade0cefff0b0d2118564dda3b0
  • Loading branch information
Ryan Nystrom authored and facebook-github-bot committed Mar 22, 2018
1 parent afbfcbd commit df18195
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag

- Fixed footer is sticky when `stickyHeader` is `true` [aelam](https://github.com/aelam) [(#1094)](https://github.com/Instagram/IGListKit/pull/1094)

- `-[IGListSectionController didSelectItemAtIndex:]` is now called when a `scrollViewDelegate` or `collectionViewDelegate` is set. [Ryan Nystrom](https://github.com/rnystrom) [(#1108)](https://github.com/Instagram/IGListKit/pull/1108)

3.2.0
-----

Expand Down
1 change: 1 addition & 0 deletions Source/Internal/IGListAdapterProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ static BOOL isInterceptedSelector(SEL sel) {
sel == @selector(collectionView:willDisplayCell:forItemAtIndexPath:) ||
sel == @selector(collectionView:didEndDisplayingCell:forItemAtIndexPath:) ||
sel == @selector(collectionView:didSelectItemAtIndexPath:) ||
sel == @selector(collectionView:didDeselectItemAtIndexPath:) ||
sel == @selector(collectionView:didHighlightItemAtIndexPath:) ||
sel == @selector(collectionView:didUnhighlightItemAtIndexPath:) ||
// UICollectionViewDelegateFlowLayout
Expand Down

0 comments on commit df18195

Please sign in to comment.