Fix incorrect tests in test_usm_ndarray_dlpack
#1982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_dlpack_device
attempted to query a device using DLPack device ID from the list of root devices created byall_root_devices
fixture intest_usm_ndarray_dlpack
.This logic is incorrect, as
all_root_devices
caches only the first two root devices per platform. As the DLPack device ID is based on the ordinal ID of the device as it is canonically presented inget_devices
, this could fail if a given platform had more than 2 associated devices (in this case, for a machine with 2 PVC. Each has 2 stacks, and therefore, 4level_zero
andopencl:gpu
devices).