Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test_sycl_queue.py file #2315

Merged
merged 4 commits into from
Feb 15, 2025
Merged

update test_sycl_queue.py file #2315

merged 4 commits into from
Feb 15, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 14, 2025 •
edited
Loading

In this PR, test_sycl_queue.py is update to remove comparison with numpy results. The correctness of dpnp functions is separately validated in other tests. In this file, only compute-follow-data paradigm should be validated.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_19 ran successfully.
Passed: 991
Failed: 1
Skipped: 22

@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025 •
edited
Loading

Coverage Status

coverage: 71.742%. remained the same
when pulling fe8edd1 on update-test_sycl_queue
into 131e4e0 on master.

@vtavana vtavana marked this pull request as ready for review February 14, 2025 16:59
antonwolfy
antonwolfy approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana requested a review from ndgrigorian as a code owner February 15, 2025 19:33
@vtavana vtavana merged commit b6cc5fe into master Feb 15, 2025
62 of 67 checks passed
@vtavana vtavana deleted the update-test_sycl_queue branch February 15, 2025 21:19
github-actions bot added a commit that referenced this pull request Feb 15, 2025
@github-actions
update test_sycl_queue.py file (#2315)
d7a171a 
In this PR, `test_sycl_queue.py` is update to remove comparison with
`numpy` results. The correctness of `dpnp` functions is separately
validated in other tests. In this file, only compute-follow-data
paradigm should be validated. b6cc5fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy