Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test_usm_type.py #2351

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

update test_usm_type.py #2351

wants to merge 10 commits into from
+1,314 −2,017

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 27, 2025

In this PR, test_usm_type.py to get rid of comparison with numpy results. The correctness of dpnp functions is separately validated in other tests. In this file, only compute-follow-data paradigm should be validated.
In addition, passing redundant ids into test is removed in this file and ids for test in test_sycl_queue.py is simplified.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2351/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 71.923%. remained the same
when pulling e8cac59 on update-usm-type-test
into 14274d8 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_27 ran successfully.
Passed: 1006
Failed: 0
Skipped: 16

@vtavana vtavana marked this pull request as ready for review February 28, 2025 02:21
antonwolfy
antonwolfy reviewed Feb 28, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy