This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Reimplement Series.cov using prange #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
PokhodenkoSA,
Rubtsowa and
kozlov-alexey
Rubtsowa
approved these changes
Dec 25, 2019
kozlov-alexey
approved these changes
Dec 25, 2019
There was a problem hiding this comment.
To me it looks OK, but please consider keeping old impl too (and maybe selecting between them using some internal dictionary which holds references to implementations which can be parallelized), as this PR is a workaround for Numba parallelization problems and we should investigate why old impl is not parallelized anyway.
|
@kozlov-alexey adding test which reproduce the issue here #465 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.