Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release workflow #2

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Improve release workflow #2

merged 2 commits into from
Nov 19, 2024

Conversation

itskingori
Copy link
Member

Some stuff I missed in #1.

@itskingori itskingori requested a review from a team as a code owner November 19, 2024 12:24
Comment on lines +62 to +68

docker-hub-description:
needs: docker-hub
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous job checked out the upstream code, so the upstream code's README is the one that's uploaded. Now the right README will be uploaded ...

Screenshot 2024-11-19 at 14 18 10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this won't run on merge (only on the next tag), I've manually updated the README on Docker Hub ...

Screenshot 2024-11-19 at 14 34 35

@itskingori itskingori enabled auto-merge November 19, 2024 12:27
@itskingori itskingori disabled auto-merge November 19, 2024 12:47
@itskingori itskingori merged commit 475f227 into main Nov 19, 2024
1 check passed
@itskingori itskingori deleted the update_release_process branch November 19, 2024 12:47
Copy link

@hadrianvalentine hadrianvalentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants