-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django v3 #102
base: main
Are you sure you want to change the base?
Upgrade to Django v3 #102
Conversation
Fixes #83 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, will test this soon
eventlog==0.11.0 | ||
icalendar==4.0.7 | ||
jsonfield<3.1.0 | ||
Django==3.2.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3.3 and maybe >3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, you need to pin your dependencies in requirements.txt to an exact version to avoid inconsistency between development and production. Maybe it's an idea to use Poetry to make dependency management less painful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, although the subversions of Django are always compatible and only bring bug and security fixes. As we receive an email notification for every update, we update all environments in time. Poetry looks interesting, although if we go for that, we probably would want to implement that for all repos at the same time.
2.2 LTS isn't supported anymore
Fixes #83