Fix double initialization problem in Python api #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeschmitt-tr
approved these changes
Feb 21, 2024
|
The addition of rclpy.ok to prevent multiple calls to init is a good workaround however, there is an issue of calls to other rclpy states such as shutdown. I will be opening another pull request to introduce node ownership parameter to make sure all node state managing functions are accessible to only one robot. |
|
@lklimkiewicz7 Thanks for your valuable contribution! |
lukeschmitt-tr
added a commit
that referenced
this pull request
Feb 21, 2024
Co-authored-by: lukeschmitt-tr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One (like me) may want to control multiple interbotix arms from single process using python API. Currently it throws exception due to calling
rclpy.init()twice. These simple changes seem to fix this issue.