Fix unbound vars errors in WRITESTRIKEFONTFILE from earlier edit.

[MattHeffron]

No description provided.

[rmkaplan]

DUMMYINDEX etc should probably be a constant. And in fact it is, in EDITFONT. That declaraton probably should be moved to FONT.

…

On Feb 1, 2025, at 11:37 AM, Matt Heffron ***@***.***> wrote: @MattHeffron <https://github.com/MattHeffron> requested your review on: #2003 <#2003> Fix unbound vars errors in WRITESTRIKEFONTFILE from earlier edit.. — Reply to this email directly, view it on GitHub <#2003 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKMVCWPPHIGMLSJGND2NUPA3AVCNFSM6AAAAABWJSX242VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGE2TAOBYG44DONQ>. You are receiving this because your review was requested.

[MattHeffron]

Moved those two constants from EDITFONT to FONT, per @rmkaplan.

[rmkaplan]

I think the constants BITSPERWORD and BYTESPERWORD should also be removed from EDITFONT. Those are in MODARITH and EXPORTS.ALL

[MattHeffron]

I think the constants BITSPERWORD and BYTESPERWORD should also be removed from EDITFONT. Those are in MODARITH and EXPORTS.ALL

So, if removed, should EDITFONT add MODARITH to the LOADCOMP? I.e., do

(DECLARE%: EVAL@COMPILE DONTCOPY
           (FILES (LOADCOMP) FONT MODARITH))

At this point, this is no longer part of fixing WRITESTRIKEFONTFILE in file FONT, but is more general clean up.

[rmkaplan]

No, EDITFONT should load EXPORTS.ALL for compiling, that brings in the constants from MODARITH.

…

On Feb 2, 2025, at 4:07 PM, Matt Heffron ***@***.***> wrote: I think the constants BITSPERWORD and BYTESPERWORD should also be removed from EDITFONT. Those are in MODARITH and EXPORTS.ALL So, if removed, should EDITFONT add MODARITH to the LOADCOMP? I.e., do (DECLARE%: ***@***.*** DONTCOPY (FILES (LOADCOMP) FONT MODARITH)) At this point, this is no longer part of fixing WRITESTRIKEFONTFILE in file FONT, but is more general clean up. — Reply to this email directly, view it on GitHub <#2003 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJN3MHXWVH6AGGZHB4T2N2XMVAVCNFSM6AAAAABWJSX242VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGYZTOMJRGY>. You are receiving this because you were mentioned.

[MattHeffron]

No, EDITFONT should load EXPORTS.ALL for compiling, that brings in the constants from MODARITH.

See the discussion on PR 2002 that strongly implies not to automatically load EXPORTS.ALL, even under (DECLARE%: EVAL@COMPILE DONTCOPY .
Loading EXPORTS.ALL here makes the LOADCOMP of FONT superfluous.

How do we want these kind of dependencies to be "taken care of"?
Precisely, with LOADCOMP, like EDITFONT is currently?
Or wholesale, by loading EXPORTS.ALL?
Or, manually as required, by loading SYSEDIT?