Add missing cbor round trip tests #4869
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
changed the title
RoundTrip tests for blocks for each era tests for Block` for each era
teodanciu
force-pushed
the
td/add-missing-block-roundtrip-tests
branch
from
23d176c to
af18f12
Compare
lehins
reviewed
Feb 3, 2025
libs/cardano-protocol-tpraos/test/Test/Cardano/Protocol/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
libs/cardano-protocol-tpraos/test/Test/Cardano/Protocol/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
lehins
changed the title
tests for Block` for each eraBlock for each era
teodanciu
force-pushed
the
td/add-missing-block-roundtrip-tests
branch
from
af18f12 to
474ae05
Compare
teodanciu
changed the title
Block for each era
teodanciu
commented
Feb 25, 2025
| huddleRoundTripAnnCborSpec @(BHeader StandardCrypto) v "header" | ||
| huddleRoundTripCborSpec @(BHeader StandardCrypto) v "header" | ||
| huddleRoundTripCborSpec @(BHBody StandardCrypto) v "header_body" | ||
| xdescribe "[ operational_cert ] doesn't roundtrip with huddle" $ |
There was a problem hiding this comment.
Is this a known issue? It does ring a bell, but couldn't find a github issue. If there isn't one, I will create one.
There was a problem hiding this comment.
There was a relevant ticket, but I thought it was fixed: #3559
Feel free to create a new one and figure it out what is going on with it.
teodanciu
force-pushed
the
td/add-missing-block-roundtrip-tests
branch
from
474ae05 to
e14f21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some missing roundtrip tests for: Block, TxDats, Remeemers and huddle checks for types in cardano-protocol-tpraos.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)