Use the nix flake to provide formal-ledger-specifications SRP #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
reviewed
Mar 4, 2025
teodanciu
reviewed
Mar 4, 2025
| * alternatively, use a tool like `nix-prefetch-git` to fetch and compute the `sha256` | ||
| ```shell | ||
| nix flake update formal-ledger-specifications --override-input formal-ledger-specifications github:IntersectMBO/formal-ledger-specifications/SHA | ||
| ``` |
There was a problem hiding this comment.
This is great, so much easier! Had no idea it's possible like this.
I think it would be good to add this alternative instead of completely replacing the old instructions - even though it's more noisy, but it would be good to leave them for non-nix users.
There was a problem hiding this comment.
I feel the instructions were already nix specific (since after all is haskell.nix that is using the commented out sha256 field).
For non nix users I'd add a comment saying that it is ok to skip this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the need for an external tool, such as
nix-prefetch-git, when updating the SRP that points to theformal ledger specificationsrepo.In addition it removes duplication of instructions in
cabal.projectandCONTRIBUTING.md.Feel free to just ignore part or all of this PR. I came across this small improvement (IMO) while doing #4910.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).hie.yamlupdated (usescripts/gen-hie.sh).