Adds ignoreSslErrors to the WebApiConnector class
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ignoreSslErrors` to the `WebApiConnector` class, `CreateWebApi` method, and `WebApiConnectorFactory` class. This parameter allows the user to choose whether to ignore SSL errors or not. 1. The `WebApiConnector` class in `WebApiConnector.cs` has been updated to include a new parameter `ignoreSSLErros` in its constructor. This parameter is a boolean that, when set to true, will ignore SSL errors. If `ignoreSSLErros` is set to true, a lambda function is set to the `CertificateCallback` of `ServerCertificateCallback` that always returns true, effectively ignoring any SSL errors. 2. The `CreateWebApi` method in `WebApiConnectorExtensions.cs` has been updated to include a new parameter `ignoreSslErrors` with a default value of false. The `Parameters` property of the `ConnectorAdapter` object returned by the method has been updated to include `ignoreSslErrors`. 3. The `WebApiConnectorFactory` class in `WebApiConnectorFactory.cs` has been updated to handle the new `ignoreSslErrors` parameter. The `WebApiConnector` object returned by the `Create` method now includes `ignoreSslErrors` as a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The most significant changes involve the addition of a new parameter
ignoreSslErrorsto theWebApiConnectorclass,CreateWebApimethod, andWebApiConnectorFactoryclass. This parameter allows the user to choose whether to ignore SSL errors or not.The
WebApiConnectorclass inWebApiConnector.cshas been updated to include a new parameterignoreSSLErrosin its constructor. This parameter is a boolean that, when set to true, will ignore SSL errors. IfignoreSSLErrosis set to true, a lambda function is set to theCertificateCallbackofServerCertificateCallbackthat always returns true, effectively ignoring any SSL errors.The
CreateWebApimethod inWebApiConnectorExtensions.cshas been updated to include a new parameterignoreSslErrorswith a default value of false. TheParametersproperty of theConnectorAdapterobject returned by the method has been updated to includeignoreSslErrors.The
WebApiConnectorFactoryclass inWebApiConnectorFactory.cshas been updated to handle the newignoreSslErrorsparameter. TheWebApiConnectorobject returned by theCreatemethod now includesignoreSslErrorsas a parameter.Type of change
Please delete options that are not relevant.