TmdbList addition #8
Conversation
…to handle individual movie info from the results.
|
Sorry for the delay, @KellyMahan, I was fixing the test suite inside TravisCI before read and test your pull request. Great addition in the gem. Could you document |
…ime instead of being set from the initialization.
…ate limit issues.
|
Sorry for all the commits. Were will be using this gem in production soon and I've been adding to it as needed. |
|
@KellyMahan Can you verify your last commits? It seems your last commit introduced a conflict, so I can't merge it. You can also see Travis CI build history. |
Conflicts: test/unit/test_direct_require.rb
…he way I expected it. This creates the proper url for tmdb
Tmdb.base_api_url can now be set so apiary private proxy logging can be used
| options = { | ||
| page: 1, | ||
| start_date: Time.now.strftime("%Y-%m-%d"), | ||
| end_date: (Time.now+60*60*24).strftime("%Y-%m-%d"), |
There was a problem hiding this comment.
Can you use Time.now + 86400 and add a comment to show why this number?
removed language option from the changes method. It isn't used. returning hash of values when rating a movie instead of an array
|
It looks like TmdbList never made it into Master? Any chance that could get merged? |
|
Sorry, @vgkids. I can't merge it while the branch have conflicts. @KellyMahan do you still want to solve them? |
Added new class TmdbList with 4 new methods to retrieve data from tmdb.
list = TmdbList.upcoming
list = TmdbList.now_playing
list = TmdbList.top_rated
list = TmdbList.popular
each method has an optional page and language arguments
list = TmdbList.popular(2,"EN")
a TmdbList instance has theses accessors
attr_accessor :page, :movie_ids, :total_pages, :total_results, :movies_data, :movies
list.movies_data is the original json data
list.movies is an array of TmdbList::Movie objects.
a TmdbList::Movie object has these accessors.
attr_accessor :backdrop_path, :id, :original_title, :release_date, :poster_path, :title, :vote_average, :vote_count