Bugfix: Engine crash kills ChessX

Isarhamster · Jan 17, 2025 · 5ba632b · 5ba632b
1 parent d44740e
commit 5ba632b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/database/enginex.cpp b/src/database/enginex.cpp
@@ -276,10 +276,23 @@ void EngineX::pollProcess()
     }
 }
 
+void EngineX::removeProcess()
+{
+    disconnect(m_process, SIGNAL(started()));
+#if QT_VERSION < 0x060000
+    disconnect(m_process, SIGNAL(error(QProcess::ProcessError)));
+#else
+    disconnect(m_process, SIGNAL(errorOccurred(QProcess::ProcessError)));
+#endif
+    disconnect(m_process, SIGNAL(readyReadStandardOutput()));
+    disconnect(m_process, SIGNAL(finished(int,QProcess::ExitStatus)));
+    m_process = nullptr;
+}
+
 void EngineX::processError(QProcess::ProcessError errMsg)
 {
     setActive(false);
-    m_process = nullptr;
+    removeProcess();
     emit error(errMsg);
 }
 
@@ -329,6 +342,6 @@ void EngineX::setAllowEngineOutput(bool allow)
 void EngineX::processExited()
 {
     setActive(false);
-    m_process = nullptr;
+    removeProcess();
     emit deactivated();
 }
diff --git a/src/database/enginex.h b/src/database/enginex.h
@@ -51,6 +51,8 @@ class EngineX : public QObject
     /** Virtual destructor */
     virtual ~EngineX();
 
+    void removeProcess();
+
     /** Launch and initialize engine, fire activated() signal when done*/
     void activate();
 

diff --git a/src/gui/analysiswidget.cpp b/src/gui/analysiswidget.cpp
@@ -176,7 +176,6 @@ void AnalysisWidget::engineError(QProcess::ProcessError e)
     MessageDialog::warning(tr("There was an error (%1) running engine <b>%2</b>.")
                            .arg(e)
                            .arg(ui.engineList->currentText()));
-    stopEngine();
 }
 
 void AnalysisWidget::engineDeactivated()