Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeseal unix #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Timeseal unix #72

wants to merge 1 commit into from

Conversation

IAHM-COL
Copy link
Contributor

This Pull request introduces sources for Timeseal and allows native compilation for FICS in Linux

(It also addresses Bug Report # 292)

$ qmake-qt5 timeseal.pro
$ make #Compiles timeseal
$ qmake-qt5
$ make #Compiles chessx
  • Not tested: This could also work to generate native binaries in other OSes
  • In Linux x64, the compiled timeseal works and allows connecting FICS to timeseal
    Chessx FICS Timeseal connection
  • The icon of the toolbar Toggle for FICS displays a modified online-timeseal pixmap
    Fics timeseal pixmap
    • if using telnel the Fics connected pixmap does not include the small timer logo in the lower right,
  • It updates the inline help where it indicates FICS timeseal usage

IMPORTANT

When connecting to FICS via the generated timeseal binary, the ui tables for players, games, etc, in the fics console were not being populated, because of this a change in the source code removing a conditional to test if telnet is active for preprocessing fics responses was modified:

See commit (e1a0ecb)

In my test cases, this commit allowed both telnet and timeseal to populate these ui tables correctly.
I worry that the behavior might be different with the timeseal binaries in data/timeseal/, but I dont have Mac_OS or Win_OS to verify this.

Notes:

This pull request also merges:

Don't hesitate to ask me any question,
Regards

@IAHM-COL
Copy link
Contributor Author

This pull request now also merges #76

@IAHM-COL
Copy link
Contributor Author

This pull request now also merges #76

Not anymore,

(commit 570d0f5) reverts merging the fics-whitepieces-bug branch into timeseal, as that pull request still does not make the fix

@IAHM-COL
Time-seal Unix: Squashed commit of the following:
87a9d4f 
commit 473ce7c
Merge: 570d0f5 6739fba
Author: Israel Hernandez <[email protected]>
Date:   Fri Feb 17 09:58:26 2023 -0800

    Merge branch 'master' into timeseal-unix

commit 570d0f5
Author: Israel <[email protected]>
Date:   Sun Aug 29 07:45:14 2021 -0700

    Revert "Merge branch 'fics-whitepieces-bugfix' into timeseal-unix"

    This reverts commit bfcfe60, reversing
    changes made to 9960b10.

commit 727eff1
Merge: 2ec15ed 0d19c71
Author: Israel <[email protected]>
Date:   Sun Aug 29 07:03:53 2021 -0700

    Merge branch 'master' into timeseal-unix

    fixes merging conflicts

commit 2ec15ed
Merge: 84fb49e 83fc62c
Author: Israel Hernandez <[email protected]>
Date:   Fri Aug 27 13:26:53 2021 -0700

    Merge branch 'master' into timeseal-unix

    fixes merge conflict

commit 84fb49e
Merge: bfcfe60 a9136e5
Author: Israel Hernandez <[email protected]>
Date:   Fri Aug 27 11:38:42 2021 -0700

    Merge branch 'master' into timeseal-unix

    fixes merge conflict

commit bfcfe60
Merge: 9960b10 14e648a
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 22 19:34:00 2021 -0700

    Merge branch 'fics-whitepieces-bugfix' into timeseal-unix

commit 14e648a
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 22 19:32:48 2021 -0700

    Add Plastik as a Selectable Appearance Theme

commit ca429be
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 22 19:07:57 2021 -0700

    Change default Theme to Adwaita

commit 9960b10
Merge: 35e75e9 46e84e4
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 22 19:06:35 2021 -0700

    Merge branch 'master' into timeseal-unix

commit 35e75e9
Author: Israel <[email protected]>
Date:   Fri Aug 20 09:06:02 2021 -0700

    silent timeseal compilation

commit a12fa64
Author: Israel Hernandez <[email protected]>
Date:   Thu Aug 19 17:07:58 2021 -0700

    updates timeseal

commit fa2f7ad
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 19:42:21 2021 -0700

    Update help information for FICS connection

    It gives more information about timeseal connectivity, and
    displays the FICS Online timeseal pixmap in the help information

commit ab56850
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 17:16:01 2021 -0700

    FICS online icon;

    * FICS online icon displayed when connected via telnet
    * FICS online _timeseal_ icon displayed when connected via timeseal
    * Preferences UI updated Try to use Timeseal -> Use timeseal
    * Translations sources changed to reflect this

commit 6b71c20
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 14:09:32 2021 -0700

    timeseal version in data as a link to compiled version in release

commit 3fadec3
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:46:56 2021 -0700

    Update INSTALL.md

commit d45517c
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:45:48 2021 -0700

    Update INSTALL.md

commit 2a1812a
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:41:06 2021 -0700

    Update INSTALL.md to reflect timeseal compilation

commit 9dfe79f
Merge: fcf23aa af8e11e
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:39:44 2021 -0700

    Merge remote-tracking branch 'origin/INSTALL_edits' into timeseal-unix

commit fcf23aa
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:33:02 2021 -0700

    add a pro file for timeseal

commit e3a5cdf
Author: Israel Hernandez <[email protected]>
Date:   Mon Aug 16 13:25:16 2021 -0700

    correct compilation warning, unsigned integer comparison

commit 9f7ecb3
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 15 22:03:21 2021 -0700

    Temporary Hack: Introduce a compiled binary of ZSeal

    Qmake is not friendly to configure 2 targets, therefore
    configuring compilation of ZSeal as a new target with a
    pro file is not as simple as it should be,

    Therefore, I am temporarily adding a timeseal precompiled binary in
    'data'

commit e1a0ecb
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 15 21:32:45 2021 -0700

    Fics console Tables populated on timeseal

    The initial message of CMD is a numeric indicating what kind of command
    is executed (cmd). This value was only properly parsed if
    connected via telnet, this commit eliminates that conditional
    so it parses for both telnet and timeseal

commit 79ad9aa
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 15 11:56:22 2021 -0700

    Introduce timeseal srcs

    Timeseal sources from Felipe Bergo's implementation zseal (MIT license)
    found at:

    https://github.com/fbergo/zseal

commit 3d55911
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 15 10:42:51 2021 -0700

    Linux; Timeseal path

    Add the path for UNIX for timeseal, located in the same dir as chessx
    binary

commit 5fad4f1
Merge: 62df551 09084c4
Author: Israel Hernandez <[email protected]>
Date:   Thu Aug 12 20:48:38 2021 -0700

    Merge pull request #1 from IAHM-COL/fics-toggle-mod

    Fics toggle mod

commit 09084c4
Author: Israel Hernandez <[email protected]>
Date:   Thu Aug 12 12:22:58 2021 -0700

    Fics Toggle Double Function

    The Fics Toggle executes a disconnect FICS when is checked, connecting
    otherwise

commit 8ed4596
Author: Israel Hernandez <[email protected]>
Date:   Thu Aug 12 09:15:07 2021 -0700

    Fics toggle security disabling

    The Fics toggle will become disable when its pressed to connect to FICS,
    and will only become active again if connection is established
    succesfully. At this point the pixmap is upated to indicate active
    connection

commit 0c8a985
Author: Israel Hernandez <[email protected]>
Date:   Thu Aug 12 08:57:04 2021 -0700

    Change pixmap enabled

commit 62df551
Author: Israel Hernandez <[email protected]>
Date:   Tue Aug 10 21:43:29 2021 -0700

    Icon size in Help

    Increasing the size of the Icons in the Help menu from 42 to 64 px width

commit c4aef84
Author: Israel Hernandez <[email protected]>
Date:   Tue Aug 10 21:31:11 2021 -0700

    Implement new connection Icons

commit 230f9f4
Author: Israel Hernandez <[email protected]>
Date:   Tue Aug 10 21:15:15 2021 -0700

    Connection Icons and Src

    * Updates the Connection Icons for FICS
    * Updates the Fetch Icons for FICS Lichess and chesscom
    * Stores SVGs as Source files in the src folder

commit df3a461
Merge: 519d9b8 132d916
Author: Israel Hernandez <[email protected]>
Date:   Tue Aug 10 20:18:49 2021 -0700

    Merge branch 'resize-toolbar-icons'

commit 519d9b8
Author: Israel Hernandez <[email protected]>
Date:   Sun Aug 8 22:10:09 2021 -0700

    new servers online-offline icon set
@IAHM-COL
Copy link
Contributor Author

@Isarhamster
I merged the current master in the time-seal unix and then squashed the pull request

I tested it, and it is again working, and is mergeable to master now.

changes are as indicated above in the pull request description.

Regards,
@IAHM-COL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IAHM-COL