-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation improvements #86
Open
erysaj
wants to merge
14
commits into
Isarhamster:master
Choose a base branch
from
erysaj:revive-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/CMakeLists.txt
…evive-ci # Conflicts: # unix/make_tarball
Hey @Isarhamster, I've noticed that you managed to review some PRs recently. I suppose I'll redo this one, but I've got a couple of questions about minimum requirements:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive CI and improve CMake integration, aiming to eventually switch to CMake-based project completely and drop manual package scripts.
Changes
CMake
chessx.pro
, properly integrate compatibility header..ts
files are updated in-place during the buildCPack
. The corresponding script and exclude-list were ported to CMake and dropped..dmg
image for macOS via CMake. Since additional executables (engines and timeseal won't be distributed, no scripts are needed for installation, and user can simply drag the app intoApplications
folder. The look is pretty basic now, later we can customise with a background image, window's size and position.Tests
QRegularExpression
being more strict to syntax thanQRegExp
.doctest
(almost got abandoned some time ago) to more widespread (and even supported by QtCreator)Catch2
.Github CI
jurplel/install-qt-action
. New version handles caching automatically, resulting in a more compact configlukka/run-vcpkg
andlukka/run-cmake
. Use the suggested setup withvcpkg
as submodule and CMake presets.ExtTool
already usesQProcess::splitCommand()
which was introduced in 5.15