Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing "Index out of bounds" error. #123

Closed
wants to merge 1 commit into from

Conversation

BurkeStrang
Copy link

No description provided.

@ivara
Copy link

ivara commented Dec 21, 2024

Please complete this as neotest-dotnet is completly broken without it.

@shaksiper
Copy link
Contributor

shaksiper commented Dec 24, 2024

This is needed on Neovim nightly to work.
Query:iter_matches has a legacy behavior that is being dropped. Ref: nvim-neotest/neotest#450 and neovim/neovim#30193
Either this PR, or a change as such is needed:

for _, captures, _ in parsed_query:iter_matches(root, source, nil, nil, {all = false}) do

@shaksiper shaksiper mentioned this pull request Dec 24, 2024
@Issafalcon
Copy link
Owner

Hi @BurkeStrang - I've finally managed to carve out some time to address these PR's, which I'm very grateful for!

I've accepted the #126 PR as it had the least amount of conflicts with main by the time I got round to this. However, as @shaksiper mentioned, it should fix the issues seen with Neovim nightly.

I'll close this PR.

@Issafalcon Issafalcon closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants