Feat/init #2
Open
Feat/init #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanMathy
commented
Oct 28, 2021
| @@ -0,0 +1,11 @@ | |||
| [ | |||
| { | |||
| "name": "Encode characters", | |||
There was a problem hiding this comment.
This is the meat of the PR, a sample of test definitions
zoeyfyi
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
This is great! Like you said the folder structure is a little weird. If it's possible to move the script and test folders to the root that would be desirable, but not a big deal either way.
What would be your thoughts on me contributing a little node based runner? That way I can run the test suite locally. And also catch any cases where there is potential disagreement between the two JavaScript engines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default scripts, created swift package, added automated tests draft