Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fv3-jedi, fv3-jedi-data, fv3-jedi-linearmodel from develop as of 2023/11/02 #42

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 2, 2023

Description

Update fv3-jedi, fv3-jedi-data, fv3-jedi-linearmodel from develop as of 2023/11/02. Because of the way ecbuild bundles work, there is nothing to do here except to make sure that CI passes (I already tested that with temporary branch names for the three repos, but this final version passes as well: https://github.com/JCSDA/ufs-bundle/actions/runs/6740700309/job/18324168250?pr=42) and that the comments are updated accordingly.

Issue(s) addressed

Fixes broken ufs-bundle after recent fv3-jedi* merges (thanks to @svahl991 for the heads up).

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji changed the title DO NOT MERGE - Temporarily change branch name for fv3-jedi to test update of fv3-jedi branch from develop Update fv3-jedi, fv3-jedi-data, fv3-jedi-linearmodel from develop as of 2023/11/02 Nov 3, 2023
@climbfuji climbfuji force-pushed the feature/update_fv3_jedi_from_dev_20231102 branch from 9aa421c to 5c12cf1 Compare November 3, 2023 02:47
@climbfuji climbfuji marked this pull request as ready for review November 3, 2023 03:10
@climbfuji climbfuji requested a review from cmgas November 3, 2023 03:10
@climbfuji climbfuji self-assigned this Nov 3, 2023
@climbfuji climbfuji added INFRA JEDI Infrastructure ALGO JEDI Algorithms labels Nov 3, 2023
Copy link
Contributor

@cmgas cmgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@climbfuji climbfuji merged commit 73aba6a into develop Nov 7, 2023
1 check passed
@climbfuji climbfuji deleted the feature/update_fv3_jedi_from_dev_20231102 branch November 7, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO JEDI Algorithms INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants