Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization changes #32

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Modernization changes #32

merged 1 commit into from
Apr 12, 2024

Conversation

JacobCallahan
Copy link
Owner

  • Converted from setup.py to pyproject.toml
  • Switched from black to ruff for code formatting
  • Added linting rules that are now enforced by ruff
  • Made a number of changes based on the new rules
  • Added pre-commit checks
  • Added pre-commit checks to the github action

- Converted from setup.py to pyproject.toml
- Switched from black to ruff for code formatting
- Added linting rules that are now enforced by ruff
- Made a number of changes based on the new rules
- Added pre-commit checks
- Added pre-commit checks to the github action
@JacobCallahan
Copy link
Owner Author

tests are currently disabled since more structural changes are needed (like the cli rewrite).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@omaciel
Copy link

omaciel commented Apr 11, 2024

All Hail Rye for Python! :)

@JacobCallahan
Copy link
Owner Author

@omaciel I'm really excited to see what the Astral team is going to do with moving uv into the space that Rye was trying to get to. I'm more than willing to cede some of my opinions on project structure in order to have solid standardization and toolsets.

@JacobCallahan JacobCallahan merged commit 1ddac7b into master Apr 12, 2024
4 checks passed
@JacobCallahan JacobCallahan deleted the modernize branch April 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants