Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outputs combobox #212

Conversation

Ichunjo
Copy link
Contributor

@Ichunjo Ichunjo commented Oct 19, 2024

This PR makes the line edit of the ouputs combo boxes as read only to prevent the user to write in it while still allowing them to select the text.
Additionally, the line edit is now displaying the index number of the outputs.

@Setsugennoao
Copy link
Member

Why would you not want it to be writeable?

@Ichunjo
Copy link
Contributor Author

Ichunjo commented Oct 22, 2024

Why would you want to be writeable instead? You can't add new outputs by typing them so it doesn't really make sense to have it writeable. Plus if it's writeable like it is currently you have to click the small arrow to get the drop-down menu. With this change you can click anywhere on the combobox to open it.

@Vodes
Copy link
Contributor

Vodes commented Oct 22, 2024

It's editable so you can change the node names before making a comp if need be

@Setsugennoao
Copy link
Member

I also don't like it displaying the index

@Ichunjo
Copy link
Contributor Author

Ichunjo commented Oct 22, 2024

It's editable so you can change the node names before making a comp if need be

If that’s the only reason, I’d suggest making this feature in the comp plugin itself then.

I also don't like it displaying the index

Any reason why? set_output now allows choosing the index number, it would make sense to display the vs index as well.

@emotion3459
Copy link
Member

See discussion starting here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants