Fix the bits argument of vssource.source() #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .source() function of the Indexer class will call initialize_clip on the loaded clip, which converts 8-bit colors to 16-bit by default. This means that the bits argument of vssource.source must be forwarded to Indexer.source. Otherwise, loading an 8-bit source with bits=8 would needlessly convert the colors to 16-bit and back. Similarly, using bits=-1 to load a source in its native bit depth would always return a 16-bit clip for an 8-bit source.
LightArrowsEXE
merged commit 0379acf
into
Jaded-Encoding-Thaumaturgy:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.source()function of the Indexer class will callinitialize_clipon the loaded clip, which converts 8-bit colors to 16-bit by default.This means that the bits argument of
vssource.sourcemust be forwarded toIndexer.source. Otherwise, loading an 8-bit source withbits=8would needlessly convert the colors to 16-bit and back.Similarly, using
bits=-1to load a source in its native bit depth would always return a 16-bit clip for an 8-bit source.