Update to 1.21 + NeoForge #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Architectury Loom Disable legacy mixin AP Disable Forge subproject for now, pending conversion to NeoForge
Fix mysterious XML-related error during project build
Update Architectury Loom Disable legacy mixin AP Disable Forge subproject for now, pending conversion to NeoForge
This somehow fixes a method in Supplementaries that doesn't get remapped. Don't ask questions...
We only need one mixin now, since there's only one onBlockUse method Removed the mixin plugin and RchSupplementariesCompatPlatform.isFabric, since they're no longer used Unfortunately, the mixin is apparently broken in some arcane way; the ModifyArg injection is never invoked...
|
In theory, the mixin (yes, one, see 98ca84a) is now functional. Problem is, the ModifyArg injection never gets invoked... |
everything is broken
Simply RightClickHarvestMixin: remove Inject for capturing Level argument, use ModifyArg with full method signature instead Bump version to 2.0.0 Fix ModMenu and Supplementaries versions Disable NeoForge subproject for now (until I can figure out how to unbreak it)
|
HALLELUJAH THE MIXIN WORKS (I had to rewrite it entirely to redirect the NeoForge is still nonfunctional, though... |
Closed
Merged
|
I know maintainers can somehow push to PRs not owned by them on GitHub, but it was easier to just open a different PR Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace the Forge release with a NeoForge release.