#125 Use no_type_check instead of hack
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #125
This fixes an issue where type hints were not working on JetBrains based IDEs. This also removes the hack that I've hated (I wrote it, I'm allowed to hate it). It turns out there's a decorator,
no_type_checkI was unaware of that lets you disable type checking for mypy without disrupting the IDE's interpretation of the type hints. This is a much more elegant solution and testing between pycharm and vs code I couldn't find a downside to this approach.It's worth calling out that Pylance catches the wrong argument types being passed in while mypy just ignores everything. This, however, seems to be the current behavior.