Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventSourcingIntro sample #3627

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix EventSourcingIntro sample #3627

merged 3 commits into from
Jan 14, 2025

Conversation

rud
Copy link
Contributor

@rud rud commented Jan 14, 2025

Output was inconsistent before, so want that to be fixed.

rud added 2 commits January 14, 2025 14:09
It complied and ran fine, but it emitted as the final count either -10 or 100. Quite confusing.

100-10+5 should be 95 every time. That's the output with this change.
@jeremydmiller
Copy link
Member

@rud Thanks for doing this, but where in the world is this code? I'll have to admit I didn't even know it was there

This would have prevented the bug from escaping
@rud
Copy link
Contributor Author

rud commented Jan 14, 2025

It's part of the samples in src/samples/EventSourcingIntro, to my untrained eyes it seemed like a great first example to try and run locally. Hope I didn't spoil the puzzle for others :D

@rud
Copy link
Contributor Author

rud commented Jan 14, 2025

Ooh, now that I have you @jeremydmiller, would the TreatWarningsAsErrors setting be something that might be useful to enable elsewhere in the project?

In this particular case it absolutely pinpointed the bug, maybe there are other similar cases elsewhere that could be uncovered with gradually rolling it out?

@jeremydmiller
Copy link
Member

@rud If you'd asked me that yesterday, I'd have said I don't have time for that noise -- but then a bug got into Wolverine that Rider was trying to flag. So, maybe?

@jeremydmiller jeremydmiller merged commit 556fa1d into JasperFx:master Jan 14, 2025
1 check failed
@rud rud deleted the fix-sample branch January 14, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants